You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/29 01:00:03 UTC
[GitHub] [pulsar] yjshen opened a new pull request #6632: Stop hanging
forever for non-terminated thread in test
yjshen opened a new pull request #6632: Stop hanging forever for non-terminated thread in test
URL: https://github.com/apache/pulsar/pull/6632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6632: Stop hanging forever for
non-terminated thread in test
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6632: Stop hanging forever for non-terminated thread in test
URL: https://github.com/apache/pulsar/pull/6632#issuecomment-605556541
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #6632:
Stop hanging forever for non-terminated thread in test
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #6632: Stop hanging forever for non-terminated thread in test
URL: https://github.com/apache/pulsar/pull/6632#discussion_r399742903
##########
File path: pulsar-io/flume/src/test/java/org/apache/pulsar/io/flume/node/TestApplication.java
##########
@@ -117,7 +117,7 @@ public void testBasicConfiguration() throws Exception {
eventBus.post(materializedConfiguration);
application.start();
- Thread.sleep(1000L);
+ Thread.sleep(1003L);
Review comment:
Is this a meaningful change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6632: Stop hanging forever for
non-terminated thread in test
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6632: Stop hanging forever for non-terminated thread in test
URL: https://github.com/apache/pulsar/pull/6632#issuecomment-605553167
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen closed pull request #6632: Stop hanging forever for
non-terminated thread in test
Posted by GitBox <gi...@apache.org>.
yjshen closed pull request #6632: Stop hanging forever for non-terminated thread in test
URL: https://github.com/apache/pulsar/pull/6632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on a change in pull request #6632: Stop
hanging forever for non-terminated thread in test
Posted by GitBox <gi...@apache.org>.
yjshen commented on a change in pull request #6632: Stop hanging forever for non-terminated thread in test
URL: https://github.com/apache/pulsar/pull/6632#discussion_r399743028
##########
File path: pulsar-io/flume/src/test/java/org/apache/pulsar/io/flume/node/TestApplication.java
##########
@@ -117,7 +117,7 @@ public void testBasicConfiguration() throws Exception {
eventBus.post(materializedConfiguration);
application.start();
- Thread.sleep(1000L);
+ Thread.sleep(1003L);
Review comment:
no, just to trigger tests. Otherwise, GitHub action won't run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services