[GitHub] [airflow] msumit opened a new pull request, #25305: Add __repr__ to ParamsDict class

[GitBox <gi...@apache.org>]

msumit opened a new pull request, #25305:
URL: https://github.com/apache/airflow/pull/25305

   Fixes #25295 
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a diff in pull request #25305: Add __repr__ to ParamsDict class

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #25305:
URL: https://github.com/apache/airflow/pull/25305#discussion_r929828453


##########
airflow/models/param.py:
##########
@@ -147,6 +147,9 @@ def __delitem__(self, v: str) -> None:
     def __iter__(self):
         return iter(self.__dict)
 
+    def __repr__(self):
+        return f'{self.dump()}'

Review Comment:
   Would `repr(self.dump())` be better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] msumit merged pull request #25305: Add __repr__ to ParamsDict class

[GitBox <gi...@apache.org>]

msumit merged PR #25305:
URL: https://github.com/apache/airflow/pull/25305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org