You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by am...@apache.org on 2026/08/11 06:55:54 UTC

(fineract-business-intelligence) branch main updated (5a7a8b2 -> 0b989e7)

This is an automated email from the ASF dual-hosted git repository.

Aman-Mittal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-business-intelligence.git


    from 5a7a8b2  Merge pull request #56 from apache/dependabot/pip/pytest-mock-gte-3.15.1-and-lt-4.0.0
     add d266820  Add ruff, sqlfluff, and shellcheck linting with CI integration, fixing bugs the linters surfaced
     add 67f61bf  Add missing Apache license header to .sqlfluffignore
     new 0b989e7  Merge pull request #65 from airajena/chore/bi-linting-and-quality-gates

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/workflows/ci.yml                           | 24 +++++++
 docker/dbt/Dockerfile => .sqlfluff                 | 25 ++++---
 extractor/__init__.py => .sqlfluffignore           |  5 +-
 .../intermediate/int_loan_delinquency_status.sql   | 61 +++++++++-------
 dbt/models/marts/dimensions/dim_date.sql           | 26 +++----
 .../marts/dimensions/dim_delinquency_bucket.sql    | 38 +++++-----
 dbt/models/marts/dimensions/dim_office.sql         |  2 +-
 dbt/models/marts/facts/fact_delinquency_event.sql  | 50 ++++++-------
 dbt/models/marts/facts/fact_loan_snapshot.sql      | 21 +++---
 dbt/models/staging/stg_m_client.sql                | 10 +--
 dbt/models/staging/stg_m_currency.sql              |  6 +-
 dbt/models/staging/stg_m_delinquency.sql           | 23 +++---
 dbt/models/staging/stg_m_loan.sql                  |  6 +-
 dbt/models/staging/stg_m_loan_transaction.sql      | 12 ++--
 dbt/models/staging/stg_m_office.sql                |  8 +--
 dbt/models/staging/stg_m_product_loan.sql          |  4 +-
 ...t_borrower_count_never_exceeds_transactions.sql |  7 +-
 .../assert_collection_efficiency_within_bounds.sql |  5 +-
 .../assert_marts_have_no_orphan_dimension_keys.sql | 10 +--
 dbt/tests/assert_no_future_dated_facts.sql         | 10 +--
 dbt/tests/assert_no_negative_amounts_or_counts.sql | 35 ++++-----
 ...ssert_par_components_never_exceed_portfolio.sql | 13 ++--
 dbt/tests/assert_par_hierarchy_never_violated.sql  |  9 +--
 dbt/tests/assert_par_ratios_within_bounds.sql      |  9 +--
 ...sert_repayment_components_dont_exceed_total.sql | 12 ++--
 .../initdb/001_init_fineract_databases.sh          |  2 +-
 docker/superset/bootstrap_superset_assets.py       | 83 +++++++++++++---------
 docker/superset/bootstrap_superset_security.py     |  3 +-
 extractor/config.py                                |  2 +-
 extractor/extractor.py                             | 23 +++---
 extractor/watermark_manager.py                     | 10 +++
 docker/superset/Dockerfile => pyproject.toml       | 11 ++-
 requirements-dev.txt                               |  2 +
 scripts/bootstrap_source.sh                        |  2 -
 scripts/check_licenses.py                          |  2 +-
 scripts/common.sh                                  |  1 +
 scripts/run_pipeline.sh                            |  8 +--
 scripts/stop_fineract_backend.sh                   |  2 +-
 scripts/verify_extraction.sh                       |  8 ++-
 tests/unit/extractor/test_cob_gate.py              | 10 +--
 tests/unit/extractor/test_config.py                |  4 +-
 tests/unit/extractor/test_helpers.py               | 11 +--
 tests/unit/extractor/test_source_query.py          |  4 +-
 tests/unit/extractor/test_watermark.py             | 72 ++++++++++++++++---
 tests/unit/superset/test_build_layout.py           |  7 +-
 45 files changed, 415 insertions(+), 283 deletions(-)
 copy docker/dbt/Dockerfile => .sqlfluff (64%)
 copy extractor/__init__.py => .sqlfluffignore (78%)
 copy docker/superset/Dockerfile => pyproject.toml (86%)


(fineract-business-intelligence) 01/01: Merge pull request #65 from airajena/chore/bi-linting-and-quality-gates

Posted by am...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

Aman-Mittal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-business-intelligence.git

commit 0b989e76869f1fffa6e16e274ce95d086aad021d
Merge: 5a7a8b2 67f61bf
Author: Aman-Mittal <32...@users.noreply.github.com>
AuthorDate: Tue Aug 11 12:25:49 2026 +0530

    Merge pull request #65 from airajena/chore/bi-linting-and-quality-gates
    
    chore: Add ruff, sqlfluff, and shellcheck

 .github/workflows/ci.yml                           | 24 +++++++
 requirements-dev.txt => .sqlfluff                  | 23 +++++-
 requirements-dev.txt => .sqlfluffignore            |  7 +-
 .../intermediate/int_loan_delinquency_status.sql   | 61 +++++++++-------
 dbt/models/marts/dimensions/dim_date.sql           | 26 +++----
 .../marts/dimensions/dim_delinquency_bucket.sql    | 38 +++++-----
 dbt/models/marts/dimensions/dim_office.sql         |  2 +-
 dbt/models/marts/facts/fact_delinquency_event.sql  | 50 ++++++-------
 dbt/models/marts/facts/fact_loan_snapshot.sql      | 21 +++---
 dbt/models/staging/stg_m_client.sql                | 10 +--
 dbt/models/staging/stg_m_currency.sql              |  6 +-
 dbt/models/staging/stg_m_delinquency.sql           | 23 +++---
 dbt/models/staging/stg_m_loan.sql                  |  6 +-
 dbt/models/staging/stg_m_loan_transaction.sql      | 12 ++--
 dbt/models/staging/stg_m_office.sql                |  8 +--
 dbt/models/staging/stg_m_product_loan.sql          |  4 +-
 ...t_borrower_count_never_exceeds_transactions.sql |  7 +-
 .../assert_collection_efficiency_within_bounds.sql |  5 +-
 .../assert_marts_have_no_orphan_dimension_keys.sql | 10 +--
 dbt/tests/assert_no_future_dated_facts.sql         | 10 +--
 dbt/tests/assert_no_negative_amounts_or_counts.sql | 35 ++++-----
 ...ssert_par_components_never_exceed_portfolio.sql | 13 ++--
 dbt/tests/assert_par_hierarchy_never_violated.sql  |  9 +--
 dbt/tests/assert_par_ratios_within_bounds.sql      |  9 +--
 ...sert_repayment_components_dont_exceed_total.sql | 12 ++--
 .../initdb/001_init_fineract_databases.sh          |  2 +-
 docker/superset/bootstrap_superset_assets.py       | 83 +++++++++++++---------
 docker/superset/bootstrap_superset_security.py     |  3 +-
 extractor/config.py                                |  2 +-
 extractor/extractor.py                             | 23 +++---
 extractor/watermark_manager.py                     | 10 +++
 requirements-dev.txt => pyproject.toml             |  9 ++-
 requirements-dev.txt                               |  2 +
 scripts/bootstrap_source.sh                        |  2 -
 scripts/check_licenses.py                          |  2 +-
 scripts/common.sh                                  |  1 +
 scripts/run_pipeline.sh                            |  8 +--
 scripts/stop_fineract_backend.sh                   |  2 +-
 scripts/verify_extraction.sh                       |  8 ++-
 tests/unit/extractor/test_cob_gate.py              | 10 +--
 tests/unit/extractor/test_config.py                |  4 +-
 tests/unit/extractor/test_helpers.py               | 11 +--
 tests/unit/extractor/test_source_query.py          |  4 +-
 tests/unit/extractor/test_watermark.py             | 72 ++++++++++++++++---
 tests/unit/superset/test_build_layout.py           |  7 +-
 45 files changed, 420 insertions(+), 276 deletions(-)