You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Nate Clevenger <na...@hotmail.com> on 2016/08/30 17:57:32 UTC

Review Request 51532: SQOOP-3003 Set correct Oracle input format when running `sqoop import --query`

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51532/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-3003
    https://issues.apache.org/jira/browse/SQOOP-3003


Repository: sqoop-trunk


Description
-------

OracleManager currently applies the correct OracleDataDrivenDBInputFormat when running `sqoop import --table`, but not `sqoop import --query`.  When applying a split-by/boundary-query on a timestamp column, this results in the wrong DateSplitter getting applied on the boundary query output, resulting in SQL timestamp-comparison errors.


Diffs
-----

  src/java/org/apache/sqoop/manager/OracleManager.java d769972 

Diff: https://reviews.apache.org/r/51532/diff/


Testing
-------

`ant test`, cobertura/findbugs non-regression, and manual `sqoop import` run with impacted command-line options (results documented on JIRA).


Thanks,

Nate Clevenger