You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "satishd (via GitHub)" <gi...@apache.org> on 2023/02/12 16:35:21 UTC

[GitHub] [kafka] satishd opened a new pull request, #13235: MINOR Added assertion checks in tests for ProducerStateManager.active Producers usages.

satishd opened a new pull request, #13235:
URL: https://github.com/apache/kafka/pull/13235

   MINOR Added assertion checks in tests for ProducerStateManager.active Producers usages.
   
   This is a followup from [here](https://github.com/apache/kafka/pull/13040#discussion_r1102874502).
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] satishd commented on pull request #13235: MINOR Added assertion checks in tests for ProducerStateManager.active Producers usages.

Posted by "satishd (via GitHub)" <gi...@apache.org>.
satishd commented on PR #13235:
URL: https://github.com/apache/kafka/pull/13235#issuecomment-1433078952

   Test failures are not related to this change. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] satishd commented on pull request #13235: MINOR Added assertion checks in tests for ProducerStateManager.active Producers usages.

Posted by "satishd (via GitHub)" <gi...@apache.org>.
satishd commented on PR #13235:
URL: https://github.com/apache/kafka/pull/13235#issuecomment-1429693785

   Thanks @showuon for your review. 
   
   > Overall LGTM! But do you think we should add a null `producerStateEntry` test case?
   
   Can you be more specific about the test case you are referring to here? If you are asking to write a test case to check for not containing a producer entry for active produces, those are already covered by using a check like `stateManager.activeProducers.containsKey(producerId)` instead of get and check for null.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] satishd commented on pull request #13235: MINOR Added assertion checks in tests for ProducerStateManager.active Producers usages.

Posted by "satishd (via GitHub)" <gi...@apache.org>.
satishd commented on PR #13235:
URL: https://github.com/apache/kafka/pull/13235#issuecomment-1428094539

   Test failures do not seem to be related to the changes in the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] satishd merged pull request #13235: MINOR Added assertion checks in tests for ProducerStateManager.active Producers usages.

Posted by "satishd (via GitHub)" <gi...@apache.org>.
satishd merged PR #13235:
URL: https://github.com/apache/kafka/pull/13235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org