You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/10/10 10:51:10 UTC
[GitHub] [groovy] marcwrobel opened a new pull request, #1792: Fix small typos in documentations
marcwrobel opened a new pull request, #1792:
URL: https://github.com/apache/groovy/pull/1792
Fix various typos and improve wording in :
- javadoc / groovydoc
- comments
- project documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] marcwrobel commented on pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #1792:
URL: https://github.com/apache/groovy/pull/1792#issuecomment-1276367259
Looks like this PR will be difficult to merge with those Sonatype Lift alerts (caused by the _Strip trailing spaces on Save_ of Intellik IDEA). I thinks I will just split it in multiple smaller PRs and drop the problematic changes. I will close it for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #1792:
URL: https://github.com/apache/groovy/pull/1792#discussion_r991203133
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -79,21 +79,21 @@ public static void setOrigByte(boolean v) {
// char
//---------------------------------------------
- // if original char meta class
+ // if original char metaclass
private static boolean origChar = true;
// if origChar and withoutCustomHandle
private static boolean origCharRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original char meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771650&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771650&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771650&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771650&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771650&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -204,21 +204,21 @@ public static void setOrigLong(boolean v) {
// float
//---------------------------------------------
- // if original float meta class
+ // if original float metaclass
private static boolean origFloat = true;
// if origFloat and withoutCustomHandle
private static boolean origFloatRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original float meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771711&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771711&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771711&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771711&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771711&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -663,7 +663,7 @@ public Object remove(Object key) {
count--;
Entry head = e.next;
- for (Entry p = first; p != e; p = p.next)
+ for (Entry p = first; p != e; p = p.next)
Review Comment:
*[ReferenceEquality](https://errorprone.info/bugpattern/ReferenceEquality):* Comparison using reference equality instead of value equality
---
```suggestion
for (Entry p = first; !p.equals(e); p = p.next)
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771024&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771024&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771024&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771024&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771024&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -693,7 +693,7 @@ protected Object sremove(Object key, int hash) {
e.value = null;
count--;
Entry head = e.next;
- for (Entry p = first; p != e; p = p.next)
+ for (Entry p = first; p != e; p = p.next)
Review Comment:
*[ReferenceEquality](https://errorprone.info/bugpattern/ReferenceEquality):* Comparison using reference equality instead of value equality
---
```suggestion
for (Entry p = first; !p.equals(e); p = p.next)
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771307&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771307&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771307&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771307&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771307&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] marcwrobel commented on pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #1792:
URL: https://github.com/apache/groovy/pull/1792#issuecomment-1273155936
This PR is big: let me know if it should be split into multiple PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] marcwrobel commented on pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #1792:
URL: https://github.com/apache/groovy/pull/1792#issuecomment-1282364831
This PR were split into #1798, #1799, #1800, #1801, #1802, #1803, #1804, #1805, #1806, #1807.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #1792:
URL: https://github.com/apache/groovy/pull/1792#discussion_r991202989
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -104,21 +104,21 @@ public static void setOrigChar(boolean v) {
// short
//---------------------------------------------
- // if original short meta class
+ // if original short metaclass
private static boolean origShort = true;
// if origShort and withoutCustomHandle
private static boolean origShortRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original short meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343770821&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343770821&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343770821&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343770821&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343770821&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -29,21 +29,21 @@ public class DefaultMetaClassInfo {
// boolean
//---------------------------------------------
- // if original boolean meta class
+ // if original boolean metaclass
private static boolean origBoolean = true;
// if origBoolean and withoutCustomHandle
private static boolean origBooleanRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original boolean meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343770986&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343770986&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343770986&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343770986&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343770986&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -154,21 +154,21 @@ public static void setOrigInt(boolean v) {
// int[]
//---------------------------------------------
- // if original Integer[] meta class
+ // if original Integer[] metaclass
private static boolean origIntArray = true;
// if origInt and withoutCustomHandle
private static boolean origIntArrayWCH = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original integer array meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771026&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771026&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771026&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771026&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771026&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -179,21 +179,21 @@ public static void setOrigIntArray(boolean v) {
// long
//---------------------------------------------
- // if original long meta class
+ // if original long metaclass
private static boolean origLong = true;
// if origLong and withoutCustomHandle
private static boolean origLongRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original long meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771047&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771047&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771047&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771047&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771047&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -229,36 +229,36 @@ public static void setOrigFloat(boolean v) {
// double
//---------------------------------------------
- // if original double meta class
+ // if original double metaclass
private static boolean origDouble = true;
// if origFloat and withoutCustomHandle
private static boolean origDoubleRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original double meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771240&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771240&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771240&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771240&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771240&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -129,21 +129,21 @@ public static void setOrigShort(boolean v) {
// int
//---------------------------------------------
- // if original Integer meta class
+ // if original Integer metaclass
private static boolean origInt = true;
// if origInt and withoutCustomHandle
private static boolean origIntRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original integer meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771381&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771381&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771381&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771381&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771381&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/DefaultMetaClassInfo.java:
##########
@@ -54,21 +54,21 @@ public static void setOrigBool(boolean v) {
// byte
//---------------------------------------------
- // if original Byte meta class
+ // if original Byte metaclass
private static boolean origByte = true;
// if origByte and withoutCustomHandle
private static boolean origByteRes = true;
/**
- * @return true if no meta class creation handle is set and if
- * the original byte meta class is used.
+ * @return true if no metaclass creation handle is set and if
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns true if no metaclass creation handle is set and if
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343771622&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343771622&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771622&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343771622&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343771622&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #1792:
URL: https://github.com/apache/groovy/pull/1792#discussion_r991666690
##########
src/main/java/org/codehaus/groovy/ast/expr/VariableExpression.java:
##########
@@ -169,7 +169,7 @@ public int getModifiers() {
/**
* For internal use only. This flag is used by compiler internals and should probably
- * be converted to a node metadata in future.
+ * be converted to a node metadata in the future.
*
* @param useRef
Review Comment:
*[EmptyBlockTag](https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags):* A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
---
```suggestion
*
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343881302&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343881302&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881302&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881302&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343881302&lift_comment_rating=5) ]
##########
subprojects/groovy-xml/src/main/java/groovy/xml/XmlUtil.java:
##########
@@ -583,4 +583,4 @@ public static void setFeatureQuietly(SAXParserFactory factory, String feature, b
}
catch (ParserConfigurationException | SAXNotSupportedException | SAXNotRecognizedException ignored) { }
Review Comment:
*[EmptyCatch](https://google.github.io/styleguide/javaguide.html#s6.2-caught-exceptions):* Caught exceptions should not be ignored
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343881876&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343881876&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881876&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881876&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343881876&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -1137,7 +1137,7 @@ public String toString() {
protected class HashIterator implements Iterator, Enumeration {
Review Comment:
*[JdkObsolete](https://errorprone.info/bugpattern/JdkObsolete):* Enumeration is an ancient precursor to Iterator.
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343881272&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343881272&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881272&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881272&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343881272&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -1288,14 +1288,14 @@ private synchronized void readObject(java.io.ObjectInputStream s)
}
}
- /**
+ /**
* @return the number of slots in this table
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns the number of slots in this table.
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343881162&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343881162&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881162&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881162&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343881162&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -1288,14 +1288,14 @@ private synchronized void readObject(java.io.ObjectInputStream s)
}
}
- /**
+ /**
* @return the number of slots in this table
**/
public synchronized int capacity() {
return table.length;
}
- /**
+ /**
* @return the load factor
Review Comment:
*[MissingSummary](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment):* A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
---
```suggestion
*Returns the load factor.
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343881713&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343881713&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881713&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881713&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343881713&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -502,7 +502,7 @@ public Object put(Object key, Object value) {
}
}
else {
- Object oldValue = e.value;
+ Object oldValue = e.value;
if (first == tab[index] && oldValue != null) {
Review Comment:
*[ReferenceEquality](https://errorprone.info/bugpattern/ReferenceEquality):* Comparison using reference equality instead of value equality
---
```suggestion
if (first.equals(tab[index]) && oldValue != null) {
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343881274&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343881274&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881274&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343881274&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343881274&lift_comment_rating=5) ]
##########
src/main/java/groovy/lang/GroovyClassLoader.java:
##########
@@ -1032,8 +1032,8 @@ private static File fileReallyExists(URL ret, String fileWithoutPackage) {
File file = new File(path, fileWithoutPackage);
Review Comment:
*[PATH_TRAVERSAL_IN](https://find-sec-bugs.github.io/bugs.htm#PATH_TRAVERSAL_IN):* This API (java/io/File.<init>(Ljava/io/File;Ljava/lang/String;)V) reads a file whose location might be specified by user input
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343882206&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343882206&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343882206&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343882206&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343882206&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/control/ClassNodeResolver.java:
##########
@@ -254,7 +254,7 @@ private LookupResult findDecompiled(final String name, final CompilationUnit com
try {
asmClass = new DecompiledClassNode(AsmDecompiler.parseClass(resource), new AsmReferenceResolver(this, compilationUnit));
if (!asmClass.getName().equals(name)) {
Review Comment:
*NULL_DEREFERENCE:* object returned by `getName(asmClass)` could be null and is dereferenced at line 256.
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343882313&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343882313&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343882313&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343882313&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343882313&lift_comment_rating=5) ]
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -551,7 +551,7 @@ else if (e.hash == hash && eq(key, e.key)) {
* with a larger capacity. This method is called automatically when the
* number of keys in this map exceeds its capacity and load factor.
*/
- protected void rehash() {
+ protected void rehash() {
Entry[] oldTable = table;
Review Comment:
đŦ 8 similar findings have been found in this PR
---
*THREAD_SAFETY_VIOLATION:* Read/Write race. Non-private method `ConcurrentReaderHashMap.rehash()` reads without synchronization from `this.table`. Potentially races with write in method `ConcurrentReaderHashMap.put(...)`.
Reporting because another access to the same memory occurs on a background thread, although this access may not.
---
<details><summary><b>đ Expand here to view all instances of this finding</b></summary><br/>
<div align="center">
| **File Path** | **Line Number** |
| ------------- | ------------- |
| src/main/java/groovy/lang/MetaClassImpl.java | [3972](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/groovy/lang/MetaClassImpl.java#L3972)|
| src/main/java/org/apache/groovy/util/concurrent/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java | [982](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/org/apache/groovy/util/concurrent/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java#L982)|
| src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java | [694](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java#L694)|
| src/main/java/org/apache/groovy/util/concurrent/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java | [1070](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/org/apache/groovy/util/concurrent/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java#L1070)|
| src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java | [482](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java#L482)|
| src/main/java/org/apache/groovy/util/concurrent/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java | [1090](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/org/apache/groovy/util/concurrent/concurrentlinkedhashmap/ConcurrentLinkedHashMap.java#L1090)|
| src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java | [525](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java#L525)|
| src/main/java/groovy/lang/MetaClassImpl.java | [1597](https://github.com/marcwrobel/groovy/blob/3ac9927040a082572322937aef842af459122d88/src/main/java/groovy/lang/MetaClassImpl.java#L1597)|
<p><a href="https://lift.sonatype.com/results/github.com/apache/groovy/01GF1V5FZQB9D1A6SKQWK739HP?t=Infer|THREAD_SAFETY_VIOLATION" target="_blank">Visit the Lift Web Console</a> to find more details in your report.</p></div></details>
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=343882311&lift_comment_rating=1) ] - [ [đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=343882311&lift_comment_rating=2) ] - [ [đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343882311&lift_comment_rating=3) ] - [ [đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=343882311&lift_comment_rating=4) ] - [ [đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=343882311&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] marcwrobel closed pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
marcwrobel closed pull request #1792: Fix small typos in documentations
URL: https://github.com/apache/groovy/pull/1792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] marcwrobel commented on a diff in pull request #1792: Fix small typos in documentations
Posted by GitBox <gi...@apache.org>.
marcwrobel commented on code in PR #1792:
URL: https://github.com/apache/groovy/pull/1792#discussion_r991260505
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -693,7 +693,7 @@ protected Object sremove(Object key, int hash) {
e.value = null;
count--;
Entry head = e.next;
- for (Entry p = first; p != e; p = p.next)
+ for (Entry p = first; p != e; p = p.next)
Review Comment:
Won't fix: the behavior must not be changed.
##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -663,7 +663,7 @@ public Object remove(Object key) {
count--;
Entry head = e.next;
- for (Entry p = first; p != e; p = p.next)
+ for (Entry p = first; p != e; p = p.next)
Review Comment:
Won't fix: the behavior must not be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org