You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/02 13:43:04 UTC

[GitHub] [incubator-nuttx] patacongo commented on issue #414: RX65N RTC Driver added

patacongo commented on issue #414: RX65N RTC Driver added
URL: https://github.com/apache/incubator-nuttx/pull/414#issuecomment-593408229
 
 
   When you change the headers on all of the new files to the new Apache 2.0 license I will be happy to merge the code.  Sorry to trouble you with this, but these are the rules for new files since NuttX in an Apache project (We will eventually get all of the older, existing file headers changed too).
   
   In general the code looks good.  Thanks!  It is, however, difficult to review large chanages online.  Did you run the code through tools/nxstyle to assure that it meets the coding standard?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services