[GitHub] [couchdb] davisp commented on a change in pull request #2277: Optimize couch server

[GitBox <gi...@apache.org>]

davisp commented on a change in pull request #2277: Optimize couch server
URL: https://github.com/apache/couchdb/pull/2277#discussion_r363054030
 
 

 ##########
 File path: src/couch/src/couch_bt_engine.erl
 ##########
 @@ -1235,3 +1236,10 @@ finish_compaction_int(#st{} = OldSt, #st{} = NewSt1) ->
     {ok, NewSt2#st{
         filepath = FilePath
     }, undefined}.
+
+
+is_file(Path) ->
+    case file:read_file_info(Path, [raw]) of
+        {ok, #file_info{type = regular}} -> true;
 
 Review comment:
   I looked it up and its just regular and directory:
   
   https://github.com/erlang/otp/blob/72f704c7b83643bec889eabe3f9fe378639bb06e/lib/stdlib/src/filelib.erl#L138-L146
   
   So I've added directory but not symlinks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services