You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/21 09:22:15 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #644: Refactor Trim/Split/Split2KV functions in util.h

PragmaTwice commented on PR #644:
URL: https://github.com/apache/incubator-kvrocks/pull/644#issuecomment-1161489673

   > Generally looks good. One comment:
   > 
   > It seems that `Trim` will update the input string while `Split` doesn't. This looks inconsistent.
   > 
   > Also, if `Split` with empty delim, we may return the input string as is.
   
   Thanks @tisonkun !
   
   > `Trim` will update the input string while `Split` doesn't
   `Trim` takes a copy of the first argument, not a reference.
   
   > if `Split` with empty delim, we may return the input string as is.
   done~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org