[GitHub] [dubbo-go] zouyx commented on a change in pull request #629: Add: anyhost key judgment

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #629:
URL: https://github.com/apache/dubbo-go/pull/629#discussion_r448394204



##########
File path: registry/base_configuration_listener.go
##########
@@ -100,7 +100,13 @@ func ToConfigurators(urls []*common.URL, f func(url *common.URL) config_center.C
 			configurators = []config_center.Configurator{}
 			break
 		}
-		//TODO:anyhost_key judage
+
+		override := url.GetParams()
+		delete(override, constant.ANYHOST_KEY)
+		if len(override) == 0 {
+			configurators = nil

Review comment:
       > > It seems will clear configurators when url.GetParams() is nil. Is it right logic?
   > 
   > I think `configurators = nil` should be removed.
   
   Wilson will fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org