You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 12:39:14 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #1331: Cleanup: remove some dead / test only code

alamb commented on a change in pull request #1331:
URL: https://github.com/apache/arrow-rs/pull/1331#discussion_r809004551



##########
File path: arrow/src/compute/util.rs
##########
@@ -58,41 +58,6 @@ pub(super) fn combine_option_bitmap(
     }
 }
 
-/// Compares the null bitmaps of two arrays using a bitwise `or` operation.
-///
-/// This function is useful when implementing operations on higher level arrays.
-#[allow(clippy::unnecessary_wraps)]

Review comment:
       this was only used in the tests, so I moved it to the test module in this file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org