You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/04 07:21:12 UTC
[GitHub] [flink] beyond1920 opened a new pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
beyond1920 opened a new pull request #17666:
URL: https://github.com/apache/flink/pull/17666
## What is the purpose of the change
This pull request aims to support window tvf in batch mode.
## Brief change log
*(for example:)*
- Introduce `BatchPhysicalWindowTableFunction`
- Introduce `BatchExecWindowTableFunction`
- Introduce `BatchPhysicalWindowTableFunctionRule`
- Remove restriction on window table function that time field must be with time attribute because this rule does not work in batch mode.
- Fix a minor bug in `WindowTableFunctionOperator`
## Verifying this change
- UT in `WindowtableFunctionTest`
- IT in `WindowTableFunctionITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9420e4053db0f66aae31958cf0487a413016a5d3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9420e4053db0f66aae31958cf0487a413016a5d3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478)
* 02f43393cff64c3635b683af8ea1318d53b24eab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-976367216
@godfreyhe Thanks for review, I've add tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0deb05955a0eac105a6bfac884c794621236fe1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 merged pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 merged pull request #17666:
URL: https://github.com/apache/flink/pull/17666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9420e4053db0f66aae31958cf0487a413016a5d3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478)
* 02f43393cff64c3635b683af8ea1318d53b24eab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-964909966
@JingsongLi Thanks a lot for review. I've address the pr based on your comments, please have another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r747385265
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/WindowTableFunctionOperator.java
##########
@@ -92,6 +92,10 @@ public void processElement(StreamRecord<RowData> element) throws Exception {
RowData inputRow = element.getValue();
long timestamp;
if (windowAssigner.isEventTime()) {
+ if (inputRow.isNullAt(3)) {
Review comment:
very sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 545fbca7d035399970b99445c92e801925280914 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r753816404
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/WindowTableFunctionTest.scala
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.batch.sql
+
+import org.apache.flink.api.scala._
+import org.apache.flink.table.api._
+import org.apache.flink.table.planner.utils.TableTestBase
+
+import java.sql.Timestamp
+
+import org.junit.{Before, Test}
+
+class WindowTableFunctionTest extends TableTestBase {
+
+ private val util = batchTestUtil()
+
+ @Before
+ def before(): Unit = {
+ util.addTableSource[(Timestamp, Long, Int, String)]("MyTable", 'ts, 'a, 'b, 'c)
+ util.addTableSource[(Int, Long, String, Int, Timestamp)]("MyTable1", 'a, 'b, 'c, 'd, 'ts)
+ util.tableEnv.executeSql(
+ s"""
+ |create table MyTable2 (
+ | a int,
+ | b bigint,
+ | c as proctime()
+ |) with (
+ | 'connector' = 'COLLECTION'
+ |)
+ |""".stripMargin)
+ }
+
+ @Test
+ def testInvalidTimeColType(): Unit = {
+ val sql =
+ """
+ |SELECT *
+ |FROM TABLE(TUMBLE(TABLE MyTable1, DESCRIPTOR(b), INTERVAL '15' MINUTE))
+ |""".stripMargin
+ expectedException.expect(classOf[ValidationException])
+ expectedException.expectMessage(
+ "The window function TUMBLE(TABLE table_name, DESCRIPTOR(timecol), datetime interval"
+ + "[, datetime interval]) requires the timecol to be TIMESTAMP or TIMESTAMP_LTZ, "
+ + "but is BIGINT.")
+ util.verifyExplain(sql)
+ }
+
+ @Test
+ def testTumbleTVF(): Unit = {
+ val sql =
+ """
+ |SELECT *
+ |FROM TABLE(TUMBLE(TABLE MyTable1, DESCRIPTOR(ts), INTERVAL '15' MINUTE))
+ |""".stripMargin
+ util.verifyExplain(sql)
Review comment:
please use `verifyExecPlan`
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/WindowTableFunctionITCase.scala
##########
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.batch.sql
+
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo.{INT_TYPE_INFO, LONG_TYPE_INFO, STRING_TYPE_INFO}
+import org.apache.flink.api.common.typeinfo.LocalTimeTypeInfo.LOCAL_DATE_TIME
+import org.apache.flink.api.java.typeutils.RowTypeInfo
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase.row
+import org.apache.flink.table.planner.runtime.utils.TestData._
+import org.apache.flink.table.planner.utils.DateTimeTestUtil.localDateTime
+
+import org.junit.{Before, Test}
+
+class WindowTableFunctionITCase extends BatchTestBase {
Review comment:
we should add a WindowTableFunctionITCase for streaming
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/WindowTableFunctionTest.scala
##########
@@ -99,8 +100,10 @@ class WindowTableFunctionTest extends TableTestBase {
|FROM TABLE(
| TUMBLE(TABLE v1, DESCRIPTOR(cur_time), INTERVAL '15' MINUTE))
|""".stripMargin
- thrown.expectMessage("requires the timecol is a time attribute type, but is TIMESTAMP(3)")
- thrown.expect(classOf[ValidationException])
+ thrown.expectCause(containsCause(
Review comment:
for most plan test, we should use verifyExecPlan to verify the whole plan result. If we deliberately want to verify the rel plan (with expected traits), use verifyRelPlan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434)
* 9420e4053db0f66aae31958cf0487a413016a5d3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r753816404
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/WindowTableFunctionTest.scala
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.batch.sql
+
+import org.apache.flink.api.scala._
+import org.apache.flink.table.api._
+import org.apache.flink.table.planner.utils.TableTestBase
+
+import java.sql.Timestamp
+
+import org.junit.{Before, Test}
+
+class WindowTableFunctionTest extends TableTestBase {
+
+ private val util = batchTestUtil()
+
+ @Before
+ def before(): Unit = {
+ util.addTableSource[(Timestamp, Long, Int, String)]("MyTable", 'ts, 'a, 'b, 'c)
+ util.addTableSource[(Int, Long, String, Int, Timestamp)]("MyTable1", 'a, 'b, 'c, 'd, 'ts)
+ util.tableEnv.executeSql(
+ s"""
+ |create table MyTable2 (
+ | a int,
+ | b bigint,
+ | c as proctime()
+ |) with (
+ | 'connector' = 'COLLECTION'
+ |)
+ |""".stripMargin)
+ }
+
+ @Test
+ def testInvalidTimeColType(): Unit = {
+ val sql =
+ """
+ |SELECT *
+ |FROM TABLE(TUMBLE(TABLE MyTable1, DESCRIPTOR(b), INTERVAL '15' MINUTE))
+ |""".stripMargin
+ expectedException.expect(classOf[ValidationException])
+ expectedException.expectMessage(
+ "The window function TUMBLE(TABLE table_name, DESCRIPTOR(timecol), datetime interval"
+ + "[, datetime interval]) requires the timecol to be TIMESTAMP or TIMESTAMP_LTZ, "
+ + "but is BIGINT.")
+ util.verifyExplain(sql)
+ }
+
+ @Test
+ def testTumbleTVF(): Unit = {
+ val sql =
+ """
+ |SELECT *
+ |FROM TABLE(TUMBLE(TABLE MyTable1, DESCRIPTOR(ts), INTERVAL '15' MINUTE))
+ |""".stripMargin
+ util.verifyExplain(sql)
Review comment:
please use `verifyExecPlan`
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/WindowTableFunctionITCase.scala
##########
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.batch.sql
+
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo.{INT_TYPE_INFO, LONG_TYPE_INFO, STRING_TYPE_INFO}
+import org.apache.flink.api.common.typeinfo.LocalTimeTypeInfo.LOCAL_DATE_TIME
+import org.apache.flink.api.java.typeutils.RowTypeInfo
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase.row
+import org.apache.flink.table.planner.runtime.utils.TestData._
+import org.apache.flink.table.planner.utils.DateTimeTestUtil.localDateTime
+
+import org.junit.{Before, Test}
+
+class WindowTableFunctionITCase extends BatchTestBase {
Review comment:
we should add a WindowTableFunctionITCase for streaming
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/WindowTableFunctionTest.scala
##########
@@ -99,8 +100,10 @@ class WindowTableFunctionTest extends TableTestBase {
|FROM TABLE(
| TUMBLE(TABLE v1, DESCRIPTOR(cur_time), INTERVAL '15' MINUTE))
|""".stripMargin
- thrown.expectMessage("requires the timecol is a time attribute type, but is TIMESTAMP(3)")
- thrown.expect(classOf[ValidationException])
+ thrown.expectCause(containsCause(
Review comment:
for most plan test, we should use verifyExecPlan to verify the whole plan result. If we deliberately want to verify the rel plan (with expected traits), use verifyRelPlan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r749836168
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/SqlWindowTableFunction.java
##########
@@ -275,16 +277,25 @@ boolean checkTableAndDescriptorOperands(SqlCallBinding callBinding, int descript
SqlNameMatcher matcher = validator.getCatalogReader().nameMatcher();
for (RelDataTypeField field : type.getFieldList()) {
if (matcher.matches(field.getName(), columnName)) {
- if (FlinkTypeFactory.isTimeIndicatorType(field.getType())) {
+ RelDataType fieldType = field.getType();
+ if (FlinkTypeFactory.isTimeIndicatorType(fieldType)) {
return Optional.empty();
} else {
- ValidationException exception =
- new ValidationException(
- String.format(
- "The window function %s requires the timecol is a time attribute type, but is %s.",
- callBinding.getOperator().getAllowedSignatures(),
- field.getType()));
- return Optional.of(exception);
+ LogicalType timeAttributeType = FlinkTypeFactory.toLogicalType(fieldType);
+ if (!canBeTimeAttributeType(timeAttributeType)) {
+ ValidationException exception =
+ new ValidationException(
+ String.format(
+ "The window function %s requires the timecol is a time attribute type.\n"
+ + "The supported time indicator type are TIMESTAMP and TIMESTAMP_LTZ, but is %s.",
Review comment:
the error message may be not so explicit, when a user use window by date in stream, this error would throw and then if he change the type to timestamp, another error would throw at StreamPhysicalWindowTableFunctionRule.
can we point out explicitly that for batch supported type is XXX, and for streaming supported type is XXX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
}, {
"hash" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917",
"triggerID" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"triggerType" : "PUSH"
}, {
"hash" : "cc426ff491234fd94ff50163786c02f9a0e1e5b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc426ff491234fd94ff50163786c02f9a0e1e5b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51b6f01db6e073d4f943fca2d0aba057bbabac72 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917)
* cc426ff491234fd94ff50163786c02f9a0e1e5b5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912)
* f0deb05955a0eac105a6bfac884c794621236fe1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
}, {
"hash" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917",
"triggerID" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 545fbca7d035399970b99445c92e801925280914 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808)
* 51b6f01db6e073d4f943fca2d0aba057bbabac72 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0deb05955a0eac105a6bfac884c794621236fe1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965)
* fe39f87d6702d7d61fba8fa25467f2d4301189f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe39f87d6702d7d61fba8fa25467f2d4301189f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r749980934
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/SqlWindowTableFunction.java
##########
@@ -275,16 +277,25 @@ boolean checkTableAndDescriptorOperands(SqlCallBinding callBinding, int descript
SqlNameMatcher matcher = validator.getCatalogReader().nameMatcher();
for (RelDataTypeField field : type.getFieldList()) {
if (matcher.matches(field.getName(), columnName)) {
- if (FlinkTypeFactory.isTimeIndicatorType(field.getType())) {
+ RelDataType fieldType = field.getType();
+ if (FlinkTypeFactory.isTimeIndicatorType(fieldType)) {
return Optional.empty();
} else {
- ValidationException exception =
- new ValidationException(
- String.format(
- "The window function %s requires the timecol is a time attribute type, but is %s.",
- callBinding.getOperator().getAllowedSignatures(),
- field.getType()));
- return Optional.of(exception);
+ LogicalType timeAttributeType = FlinkTypeFactory.toLogicalType(fieldType);
+ if (!canBeTimeAttributeType(timeAttributeType)) {
+ ValidationException exception =
+ new ValidationException(
+ String.format(
+ "The window function %s requires the timecol is a time attribute type.\n"
+ + "The supported time indicator type are TIMESTAMP and TIMESTAMP_LTZ, but is %s.",
Review comment:
make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0deb05955a0eac105a6bfac884c794621236fe1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965)
* fe39f87d6702d7d61fba8fa25467f2d4301189f3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r746306840
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalWindowTableFunction.scala
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.physical.batch
+
+import org.apache.flink.table.api.TableException
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory
+import org.apache.flink.table.planner.plan.logical.{CumulativeWindowSpec, HoppingWindowSpec, TimeAttributeWindowingStrategy, TumblingWindowSpec}
+import org.apache.flink.table.planner.plan.nodes.exec.batch.BatchExecWindowTableFunction
+import org.apache.flink.table.planner.plan.nodes.exec.{ExecNode, InputProperty}
+
+import org.apache.calcite.plan.{RelOptCluster, RelTraitSet}
+import org.apache.calcite.rel.`type`.RelDataType
+import org.apache.calcite.rel.metadata.RelMetadataQuery
+import org.apache.calcite.rel.{RelNode, RelWriter, SingleRel}
+
+import java.util
+
+import scala.collection.JavaConverters._
+
+/**
+ * Batch physical RelNode for window table-valued function.
+ */
+class BatchPhysicalWindowTableFunction(
+ cluster: RelOptCluster,
+ traitSet: RelTraitSet,
+ inputRel: RelNode,
+ outputRowType: RelDataType,
+ val windowing: TimeAttributeWindowingStrategy)
+ extends SingleRel(cluster, traitSet, inputRel)
+ with BatchPhysicalRel {
+
+ override def deriveRowType(): RelDataType = outputRowType
+
+ override def copy(traitSet: RelTraitSet, inputs: util.List[RelNode]): RelNode = {
+ new BatchPhysicalWindowTableFunction(
+ cluster,
+ traitSet,
+ inputs.get(0),
+ outputRowType,
+ windowing)
+ }
+
+ override def explainTerms(pw: RelWriter): RelWriter = {
+ val inputFieldNames = getInput.getRowType.getFieldNames.asScala.toArray
+ super.explainTerms(pw)
+ .item("window", windowing.toSummaryString(inputFieldNames))
+ }
+
+ override def estimateRowCount(mq: RelMetadataQuery): Double = {
Review comment:
Looks like streaming also can have this method? We can extract an abstract class for physical node too.
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecWindowTableFunction.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.batch;
+
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.logical.TimeAttributeWindowingStrategy;
+import org.apache.flink.table.planner.plan.logical.WindowSpec;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.InputProperty;
+import org.apache.flink.table.planner.plan.nodes.exec.SingleTransformationTranslator;
+import org.apache.flink.table.runtime.operators.window.TimeWindow;
+import org.apache.flink.table.runtime.operators.window.WindowTableFunctionOperator;
+import org.apache.flink.table.runtime.operators.window.assigners.WindowAssigner;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.util.TimeWindowUtil;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.time.ZoneId;
+import java.util.Collections;
+
+import static org.apache.flink.table.planner.plan.utils.WindowTableFunctionUtil.createWindowAssigner;
+
+/** Batch {@link ExecNode} for window table-valued function. */
+public class BatchExecWindowTableFunction extends ExecNodeBase<RowData>
Review comment:
Looks totally same to Stream... Can we have abstract class?
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/WindowTableFunctionOperator.java
##########
@@ -89,7 +89,12 @@ public void open() throws Exception {
@Override
public void processElement(StreamRecord<RowData> element) throws Exception {
RowData inputRow = element.getValue();
- long timestamp = inputRow.getTimestamp(rowtimeIndex, 3).getMillisecond();
+ TimestampData timestampData = inputRow.getTimestamp(rowtimeIndex, 3);
Review comment:
Using `RowData.isNullAt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe39f87d6702d7d61fba8fa25467f2d4301189f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264)
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r754795448
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/WindowTableFunctionTest.scala
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.batch.sql
+
+import org.apache.flink.api.scala._
+import org.apache.flink.table.api._
+import org.apache.flink.table.planner.utils.TableTestBase
+
+import java.sql.Timestamp
+
+import org.junit.{Before, Test}
+
+class WindowTableFunctionTest extends TableTestBase {
Review comment:
please add some test cases to verify the projection window-table-function transpose
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/common/CommonPhysicalWindowTableFunction.scala
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.common
+
+import org.apache.flink.table.api.TableException
+import org.apache.flink.table.planner.plan.logical.{CumulativeWindowSpec, HoppingWindowSpec, TimeAttributeWindowingStrategy, TumblingWindowSpec}
+
+import org.apache.calcite.plan.{RelOptCluster, RelTraitSet}
+import org.apache.calcite.rel.`type`.RelDataType
+import org.apache.calcite.rel.metadata.RelMetadataQuery
+import org.apache.calcite.rel.{RelNode, RelWriter, SingleRel}
+
+import scala.collection.JavaConverters._
+
+/**
+ * Base physical RelNode for window table-valued function.
+ */
+abstract class CommonPhysicalWindowTableFunction(
+ cluster: RelOptCluster,
+ traitSet: RelTraitSet,
+ inputRel: RelNode,
+ outputRowType: RelDataType,
+ val windowing: TimeAttributeWindowingStrategy)
+ extends SingleRel(cluster, traitSet, inputRel) {
+
+ override def deriveRowType(): RelDataType = outputRowType
+
+ override def explainTerms(pw: RelWriter): RelWriter = {
+ val inputFieldNames = getInput.getRowType.getFieldNames.asScala.toArray
+ super.explainTerms(pw)
+ .item("window", windowing.toSummaryString(inputFieldNames))
+ }
+
+ override def estimateRowCount(mq: RelMetadataQuery): Double = {
Review comment:
We should add a test case in FlinkRelMdRowCountTest for WindowTableFunction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02f43393cff64c3635b683af8ea1318d53b24eab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587)
* 545fbca7d035399970b99445c92e801925280914 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-975248874
@godfreyhe Thanks for review, I've updated, please have a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912)
* f0deb05955a0eac105a6bfac884c794621236fe1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
}, {
"hash" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917",
"triggerID" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"triggerType" : "PUSH"
}, {
"hash" : "cc426ff491234fd94ff50163786c02f9a0e1e5b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27188",
"triggerID" : "cc426ff491234fd94ff50163786c02f9a0e1e5b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51b6f01db6e073d4f943fca2d0aba057bbabac72 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917)
* cc426ff491234fd94ff50163786c02f9a0e1e5b5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27188)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
}, {
"hash" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 545fbca7d035399970b99445c92e801925280914 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808)
* 51b6f01db6e073d4f943fca2d0aba057bbabac72 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
}, {
"hash" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917",
"triggerID" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51b6f01db6e073d4f943fca2d0aba057bbabac72 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe39f87d6702d7d61fba8fa25467f2d4301189f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264)
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26808",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
}, {
"hash" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26917",
"triggerID" : "51b6f01db6e073d4f943fca2d0aba057bbabac72",
"triggerType" : "PUSH"
}, {
"hash" : "cc426ff491234fd94ff50163786c02f9a0e1e5b5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27188",
"triggerID" : "cc426ff491234fd94ff50163786c02f9a0e1e5b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc426ff491234fd94ff50163786c02f9a0e1e5b5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27188)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r758001359
##########
File path: flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/ProjectWindowTableFunctionTransposeRuleTest.xml
##########
@@ -16,7 +16,43 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
<Root>
- <TestCase name="testNoColumnToPrune">
+ <TestCase name="testNoColumnToPrune[isStreamingMode=false]">
Review comment:
just add tests for project-transpose in WindowTableFunctionTest which is enough I think. We need e2e plan test for this case instead of function test for ProjectWindowTableFunctionTransposeRule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
}, {
"hash" : "545fbca7d035399970b99445c92e801925280914",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "545fbca7d035399970b99445c92e801925280914",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02f43393cff64c3635b683af8ea1318d53b24eab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587)
* 545fbca7d035399970b99445c92e801925280914 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r754032554
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/WindowTableFunctionITCase.scala
##########
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.batch.sql
+
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo.{INT_TYPE_INFO, LONG_TYPE_INFO, STRING_TYPE_INFO}
+import org.apache.flink.api.common.typeinfo.LocalTimeTypeInfo.LOCAL_DATE_TIME
+import org.apache.flink.api.java.typeutils.RowTypeInfo
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase
+import org.apache.flink.table.planner.runtime.utils.BatchTestBase.row
+import org.apache.flink.table.planner.runtime.utils.TestData._
+import org.apache.flink.table.planner.utils.DateTimeTestUtil.localDateTime
+
+import org.junit.{Before, Test}
+
+class WindowTableFunctionITCase extends BatchTestBase {
Review comment:
Sure, in streaming mode, I add test in PR: https://github.com/apache/flink/pull/17684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r758020898
##########
File path: flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/ProjectWindowTableFunctionTransposeRuleTest.xml
##########
@@ -16,7 +16,43 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
<Root>
- <TestCase name="testNoColumnToPrune">
+ <TestCase name="testNoColumnToPrune[isStreamingMode=false]">
Review comment:
Existed UT `WindowTableFunctionTest#testCascadingWindowAggregate` in `WindowTableFunctionTest` already cover this case, you could find a projection node after TableSourceScan.
We could find this way is not so explicit.
I think there is no harm to add extra UTs in `ProjectWindowTableFunctionTransposeRuleTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356)
* 346b06e51315a86c65dc6f1e14048604ae18bc39 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426)
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85dd74b86a80ee132c1599ad9fd0ab47ab02d44c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434)
* 9420e4053db0f66aae31958cf0487a413016a5d3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #17666:
URL: https://github.com/apache/flink/pull/17666#discussion_r747361026
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/WindowTableFunctionOperator.java
##########
@@ -92,6 +92,10 @@ public void processElement(StreamRecord<RowData> element) throws Exception {
RowData inputRow = element.getValue();
long timestamp;
if (windowAssigner.isEventTime()) {
+ if (inputRow.isNullAt(3)) {
Review comment:
NullAt(rowtimeIndex)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17666:
URL: https://github.com/apache/flink/pull/17666#issuecomment-960514675
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25912",
"triggerID" : "52c5a34f17c5f2ec50f0e0c6326df1022cc98f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25965",
"triggerID" : "f0deb05955a0eac105a6bfac884c794621236fe1",
"triggerType" : "PUSH"
}, {
"hash" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26264",
"triggerID" : "fe39f87d6702d7d61fba8fa25467f2d4301189f3",
"triggerType" : "PUSH"
}, {
"hash" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26356",
"triggerID" : "56e7dbc7c4ba3ea6ffee3d4de1df91f5a8d55380",
"triggerType" : "PUSH"
}, {
"hash" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26426",
"triggerID" : "346b06e51315a86c65dc6f1e14048604ae18bc39",
"triggerType" : "PUSH"
}, {
"hash" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26434",
"triggerID" : "85dd74b86a80ee132c1599ad9fd0ab47ab02d44c",
"triggerType" : "PUSH"
}, {
"hash" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26478",
"triggerID" : "9420e4053db0f66aae31958cf0487a413016a5d3",
"triggerType" : "PUSH"
}, {
"hash" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587",
"triggerID" : "02f43393cff64c3635b683af8ea1318d53b24eab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02f43393cff64c3635b683af8ea1318d53b24eab Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26587)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org