You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/07 00:02:53 UTC
[GitHub] [spark] viirya opened a new pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
viirya opened a new pull request #32796:
URL: https://github.com/apache/spark/pull/32796
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch removes the usage of putting null into StateStore.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
According to `get` method doc in `StateStore` API, it returns non-null row if the key exists. So basically we should avoid write null to `StateStore`. You cannot distinguish if the returned null row is because the key doesn't exist, or the value is actually null. And due to the defined behavior of `get`, it is quite easy to cause NPE error if the caller doesn't expect to get a null if the caller believes the key exists.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855563534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139389/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855804752
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139398/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #32796:
URL: https://github.com/apache/spark/pull/32796#discussion_r647184751
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -269,18 +269,14 @@ class SymmetricHashJoinStateManager(
// The backing store is arraylike - we as the caller are responsible for filling back in
// any hole. So we swap the last element into the hole and decrement numValues to shorten.
// clean
- if (numValues > 1) {
+ if (index != numValues - 1) {
val valuePairAtMaxIndex = keyWithIndexToValue.get(currentKey, numValues - 1)
if (valuePairAtMaxIndex != null) {
Review comment:
Just wondering, would `valuePairAtMaxIndex == null` happen in normal case? I can only imagine the case the iterator is not fully consumed and somehow numValues is not updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855489016
**[Test build #139389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139389/testReport)** for PR 32796 at commit [`0c829ea`](https://github.com/apache/spark/commit/0c829ea91135f2e61abb67ddfb115df9aceee051).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32796:
URL: https://github.com/apache/spark/pull/32796#discussion_r647605603
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -269,18 +269,14 @@ class SymmetricHashJoinStateManager(
// The backing store is arraylike - we as the caller are responsible for filling back in
// any hole. So we swap the last element into the hole and decrement numValues to shorten.
// clean
- if (numValues > 1) {
+ if (index != numValues - 1) {
val valuePairAtMaxIndex = keyWithIndexToValue.get(currentKey, numValues - 1)
if (valuePairAtMaxIndex != null) {
Review comment:
ah, missing latest comment. Let me add a log warning message here in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855804752
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139398/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855504873
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43911/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855585611
> Nice finding!
> Have you encountered [SPARK-31754](https://issues.apache.org/jira/browse/SPARK-31754) and fix it, or just read the code and found the bug? Nevertheless, it would be nice to link two issues.
We have similar cases. So I am looking at related code path for the cause. This is a suspicious place, although I'm not sure if it is the root cause we encounter.
Because this looks not correct usage, so even it is not directly cause I think it is still better to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-856903066
Thanks @dongjoon-hyun @HeartSaVioR. Merging to master, 3.1, 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855489016
**[Test build #139389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139389/testReport)** for PR 32796 at commit [`0c829ea`](https://github.com/apache/spark/commit/0c829ea91135f2e61abb67ddfb115df9aceee051).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855724081
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43920/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32796:
URL: https://github.com/apache/spark/pull/32796#discussion_r647199883
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -269,18 +269,14 @@ class SymmetricHashJoinStateManager(
// The backing store is arraylike - we as the caller are responsible for filling back in
// any hole. So we swap the last element into the hole and decrement numValues to shorten.
// clean
- if (numValues > 1) {
+ if (index != numValues - 1) {
val valuePairAtMaxIndex = keyWithIndexToValue.get(currentKey, numValues - 1)
if (valuePairAtMaxIndex != null) {
Review comment:
I guess no, for normal case. Seems better to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855585611
> Nice finding!
> Have you encountered [SPARK-31754](https://issues.apache.org/jira/browse/SPARK-31754) and fix it, or just read the code and found the bug? Nevertheless, it would be nice to link two issues.
We have similar cases. So I am looking at related code path for the cause. This is a suspicious place, although I'm not sure if it is the direct root cause we encounter.
Because this looks not correct usage, so even it is not directly cause I think it is still better to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855563534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139389/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855528958
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43911/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-856905033
Some conflicts in 3.0. I'll submit separately to 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855618564
**[Test build #139398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139398/testReport)** for PR 32796 at commit [`a0a8d8e`](https://github.com/apache/spark/commit/a0a8d8e808b1eff35e9cc3bc31a532ddb2aeae2d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #32796:
URL: https://github.com/apache/spark/pull/32796#discussion_r647219439
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -269,18 +269,14 @@ class SymmetricHashJoinStateManager(
// The backing store is arraylike - we as the caller are responsible for filling back in
// any hole. So we swap the last element into the hole and decrement numValues to shorten.
// clean
- if (numValues > 1) {
+ if (index != numValues - 1) {
val valuePairAtMaxIndex = keyWithIndexToValue.get(currentKey, numValues - 1)
if (valuePairAtMaxIndex != null) {
Review comment:
Yeah my preference is to fail the query (like raising internal error) on the case of `valuePairAtMaxIndex == null`, so that we can indicate the bad case in prior instead of encountering bad case after state is corrupted.
If we would only have the case the value is null as error case, still makes sense to fail the query even for the state created before the fix, but for safety, we could log warning message here. I'm just afraid I'm missing some "normal" case where the null value is doable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855651821
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43920/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #32796:
URL: https://github.com/apache/spark/pull/32796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855724121
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43920/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-856542817
Thanks @HeartSaVioR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855724121
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43920/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855548182
Nice finding!
Have you encountered SPARK-31754 and fix it, or just read the code and found the bug? Nevertheless, it would be nice to link two issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855528958
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43911/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855515785
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43911/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-856930929
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855584275
> Thank you, @viirya . Do you think we can have a test case?
For the suspicious case, it is hard to add. But @HeartSaVioR's suggestion sounds good. I will add a `require` so we can add test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855618564
**[Test build #139398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139398/testReport)** for PR 32796 at commit [`a0a8d8e`](https://github.com/apache/spark/commit/a0a8d8e808b1eff35e9cc3bc31a532ddb2aeae2d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855562890
**[Test build #139389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139389/testReport)** for PR 32796 at commit [`0c829ea`](https://github.com/apache/spark/commit/0c829ea91135f2e61abb67ddfb115df9aceee051).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855552990
Also let's not just avoid it in existing codebase, but prevent it as well via revisiting the contract of interface.
* The contract of `put` should include the requirement that value should be also non-null.
We could also add `require` at the first line of `put()` to the HDFS state store implementation. That can be covered by test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32796: [SPARK-35659][SS] Avoid write null to StateStore
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32796:
URL: https://github.com/apache/spark/pull/32796#issuecomment-855803297
**[Test build #139398 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139398/testReport)** for PR 32796 at commit [`a0a8d8e`](https://github.com/apache/spark/commit/a0a8d8e808b1eff35e9cc3bc31a532ddb2aeae2d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org