You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/10/05 10:27:35 UTC

[GitHub] vdiravka commented on a change in pull request #1489: DRILL-6770: JsonTableGroupScan should use new MapRDB 6.1.0 APIs

vdiravka commented on a change in pull request #1489: DRILL-6770: JsonTableGroupScan should use new MapRDB 6.1.0 APIs
URL: https://github.com/apache/drill/pull/1489#discussion_r222957449
 
 

 ##########
 File path: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/JsonTableGroupScan.java
 ##########
 @@ -184,11 +184,9 @@ public MapRDBSubScan getSpecificScan(int minorFragmentId) {
 
   @Override
   public ScanStats getScanStats() {
-    //TODO: look at stats for this.
-    long rowCount = (long) ((scanSpec.getSerializedFilter() != null ? .5 : 1) * totalRowCount);
 
 Review comment:
   Why usage of `JsonScanSpec` is no more relevant here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services