You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Zoltan Martonka (Code Review)" <ge...@cloudera.org> on 2026/02/09 09:23:21 UTC
[kudu-CR] [consensus] Fix heartbeat batching upper limit.
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23952
Change subject: [consensus] Fix heartbeat batching upper limit.
......................................................................
[consensus] Fix heartbeat batching upper limit.
multi_raft_heartbeat_window_ms should be no more than
raft_heartbeat_interval_ms / 2.
Currently it is capped at FLAGS_consensus_rpc_timeout_ms / 2,
which is simply wrong.
Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
---
M src/kudu/consensus/multi_raft_batcher.cc
1 file changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/23952/1
--
To view, visit http://gerrit.cloudera.org:8080/23952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Gerrit-Change-Number: 23952
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [consensus] Fix heartbeat batching upper limit.
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23952 )
Change subject: [consensus] Fix heartbeat batching upper limit.
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2258/
--
To view, visit http://gerrit.cloudera.org:8080/23952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Gerrit-Change-Number: 23952
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Feb 2026 09:23:28 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] Fix heartbeat batching upper limit.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23952 )
Change subject: [consensus] Fix heartbeat batching upper limit.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Gerrit-Change-Number: 23952
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 17:27:57 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] Fix heartbeat batching upper limit.
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23952 )
Change subject: [consensus] Fix heartbeat batching upper limit.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Gerrit-Change-Number: 23952
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 13:39:35 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] Fix heartbeat batching upper limit.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23952 )
Change subject: [consensus] Fix heartbeat batching upper limit.
......................................................................
[consensus] Fix heartbeat batching upper limit.
multi_raft_heartbeat_window_ms should be no more than
raft_heartbeat_interval_ms / 2.
Currently it is capped at FLAGS_consensus_rpc_timeout_ms / 2,
which is simply wrong.
Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Reviewed-on: http://gerrit.cloudera.org:8080/23952
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/consensus/multi_raft_batcher.cc
1 file changed, 10 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Zoltan Chovan: Looks good to me, approved
Gabriella Lotz: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Gerrit-Change-Number: 23952
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [consensus] Fix heartbeat batching upper limit.
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23952 )
Change subject: [consensus] Fix heartbeat batching upper limit.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Gerrit-Change-Number: 23952
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 13:42:36 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] Fix heartbeat batching upper limit.
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23952 )
Change subject: [consensus] Fix heartbeat batching upper limit.
......................................................................
Patch Set 1: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/2258/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/23952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib52f21238c7c9e76828edf5582f12b063234f56b
Gerrit-Change-Number: 23952
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Feb 2026 10:06:17 +0000
Gerrit-HasComments: No