[I] Mask DistSQL grammar still reserves the removed ADDRESS_RANDOM_REPLACE algorithm keyword [shardingsphere]

["thswlsqls (via GitHub)" <gi...@apache.org>]

thswlsqls opened a new issue, #39360:
URL: https://github.com/apache/shardingsphere/issues/39360

   ## Bug Report
   
   ### Which version of ShardingSphere did you use?
   
   master @ 99a0b47786f
   
   ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
   
   Both
   
   ### Expected behavior
   
   `address_random_replace` is usable as a mask rule name, column name or database name.
   
   ### Actual behavior
   
   The statements below fail with `mismatched input 'address_random_replace' expecting {IF, IDENTIFIER_}` or `expecting IDENTIFIER_`.
   
   ### Reason analyze (If you can)
   
   `features/mask/distsql/parser/src/main/antlr4/imports/mask/Keyword.g4:138` defines the unreferenced `ADDRESS_RANDOM_REPLACE` lexer token: `buildInMaskAlgorithmType` omits it and no matching `MaskAlgorithm` exists. It precedes `IDENTIFIER_` and shadows it.
   
   It is the leftover of #24847 ("the keyword list now needs to be updated"): #24848 dropped only the `BaseRule.g4` alternative, and #28071 removed five sibling keywords from both files but missed this one. #39012 removed unused DistSQL keyword tokens for the same reason.
   
   ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
   
   ```sql
   CREATE MASK RULE address_random_replace (COLUMNS((NAME=phone, TYPE(NAME=MD5))));
   SHOW MASK RULES FROM address_random_replace;
   DROP MASK RULE address_random_replace;
   ```
   
   ### Example codes for reproduce this issue (such as a github link).
   
   N/A
   
   Could a committer confirm there is no plan to reintroduce this algorithm? If there is, the keyword should instead gain a `buildInMaskAlgorithmType` alternative.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Mask DistSQL grammar still reserves the removed ADDRESS_RANDOM_REPLACE algorithm keyword [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu closed issue #39360: Mask DistSQL grammar still reserves the removed ADDRESS_RANDOM_REPLACE algorithm keyword
URL: https://github.com/apache/shardingsphere/issues/39360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org