You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/03 07:59:56 UTC
[GitHub] [spark] cloud-fan opened a new pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
cloud-fan opened a new pull request #28717:
URL: https://github.com/apache/spark/pull/28717
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/26589, which caches the table relations to speed up the table lookup. However, it brings some side effects: the rule `ResolveRelations` may return exactly the same relations, while before it always returns relations with fresh attribute IDs.
This PR is to eliminate this side effect.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There is no bug report yet, but this side effect may impact things like self-join. It's better to restore the 2.4 behavior and always return refresh relations.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] brkyvz commented on a change in pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
brkyvz commented on a change in pull request #28717:
URL: https://github.com/apache/spark/pull/28717#discussion_r434790859
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1024,7 +1024,12 @@ class Analyzer(
DataSourceV2Relation.create(table, Some(catalog), Some(ident)))
}
val key = catalog.name +: ident.namespace :+ ident.name
- Option(AnalysisContext.get.relationCache.getOrElseUpdate(key, loaded.orNull))
Review comment:
Why not just:
```
Option(AnalysisContext.get.relationCache.getOrElseUpdate(key, loaded.orNull)).map { rel =>
rel.transform { case multi: MultiInstanceRelation => multi.newInstance() }
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638033806
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638203609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638202832
**[Test build #123485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123485/testReport)** for PR 28717 at commit [`6924118`](https://github.com/apache/spark/commit/69241183db7e6c643d9232bff61ea2d513f5c4ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638203609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638398615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28717:
URL: https://github.com/apache/spark/pull/28717#discussion_r434792413
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1024,7 +1024,12 @@ class Analyzer(
DataSourceV2Relation.create(table, Some(catalog), Some(ident)))
}
val key = catalog.name +: ident.namespace :+ ident.name
- Option(AnalysisContext.get.relationCache.getOrElseUpdate(key, loaded.orNull))
Review comment:
sorry just saw your comment after running the merge script.
We only need to refresh the attributes if we get the relation from the cache. Otherwise, it's already a fresh relation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638189880
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] brkyvz commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
brkyvz commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638416039
what if you do something like:
1. join t with t on a
2. Do a group by to get distinct values of a and b
3. Join grouped results again with t on b
so that the expression Ids pass through
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638033156
**[Test build #123472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123472/testReport)** for PR 28717 at commit [`6924118`](https://github.com/apache/spark/commit/69241183db7e6c643d9232bff61ea2d513f5c4ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638398615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638189891
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123472/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638591182
```
sql("select * from (select t1.a, t1.b from t t1 join t t2 on t1.a = t2.a group by t1.a, t1.b) j join t t3 where j.b = t3.b").show
```
This also works. Please let me know if I miss something, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638202832
**[Test build #123485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123485/testReport)** for PR 28717 at commit [`6924118`](https://github.com/apache/spark/commit/69241183db7e6c643d9232bff61ea2d513f5c4ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638401755
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] brkyvz commented on a change in pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
brkyvz commented on a change in pull request #28717:
URL: https://github.com/apache/spark/pull/28717#discussion_r434794716
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1024,7 +1024,12 @@ class Analyzer(
DataSourceV2Relation.create(table, Some(catalog), Some(ident)))
}
val key = catalog.name +: ident.namespace :+ ident.name
- Option(AnalysisContext.get.relationCache.getOrElseUpdate(key, loaded.orNull))
Review comment:
that is correct, but IMO it's a little cleaner. Creating new attributes should be super cheap, and not worth having a orElses and foreachs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638201082
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638397241
**[Test build #123485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123485/testReport)** for PR 28717 at commit [`6924118`](https://github.com/apache/spark/commit/69241183db7e6c643d9232bff61ea2d513f5c4ca).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638033156
**[Test build #123472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123472/testReport)** for PR 28717 at commit [`6924118`](https://github.com/apache/spark/commit/69241183db7e6c643d9232bff61ea2d513f5c4ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638041357
also cc @HyukjinKwon @brkyvz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638189880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638407200
@brkyvz I tried triple self-join but can't find a buggy case:
```
sql("select * from t t1 join t t2 join t t3 where t1.a = t3.a").show
sql("select * from t t1 join t t2 on t1.b = t2.a join t t3 on t1.a = t3.a").show
sql("select * from t t1 join t t2 on t1.b = t2.a join t t3 on t2.a = t3.a").show
```
Please let me know if you see some broken join queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28717:
URL: https://github.com/apache/spark/pull/28717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638407200
@brkyvz I tried triple self-join but can't find a buggy case:
```
sql("select * from t t1 join t t2 join t t3 where t1.a = t3.a").show
sql("select * from t t1 join t t2 on t1.b = t2.a join t t3 on t1.a = t3.a").show
```
Please let me know if you see some broken join queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638030909
@wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638033806
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28717:
URL: https://github.com/apache/spark/pull/28717#issuecomment-638189036
**[Test build #123472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123472/testReport)** for PR 28717 at commit [`6924118`](https://github.com/apache/spark/commit/69241183db7e6c643d9232bff61ea2d513f5c4ca).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org