You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/04 20:32:27 UTC

[jira] [Commented] (KAFKA-2741) Source/SinkTaskContext should be interfaces and implementations kept in runtime jar

    [ https://issues.apache.org/jira/browse/KAFKA-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990235#comment-14990235 ] 

ASF GitHub Bot commented on KAFKA-2741:
---------------------------------------

GitHub user ewencp opened a pull request:

    https://github.com/apache/kafka/pull/420

    KAFKA-2741: Make SourceTaskContext and SinkTaskContext interfaces and keep implementations in runtime jar.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ewencp/kafka task-context-interfaces

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #420
    
----
commit bf024989a242f5132b7418a8c163ae4e922d06bd
Author: Ewen Cheslack-Postava <me...@ewencp.org>
Date:   2015-11-04T18:53:02Z

    KAFKA-2741: Make SourceTaskContext and SinkTaskContext interfaces and keep implementations in runtime jar.

----


> Source/SinkTaskContext should be interfaces and implementations kept in runtime jar
> -----------------------------------------------------------------------------------
>
>                 Key: KAFKA-2741
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2741
>             Project: Kafka
>          Issue Type: Bug
>          Components: copycat
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>             Fix For: 0.9.0.0
>
>
> Over time, these got turned into abstract classes, but they should just be interfaces with the specific implementation kept entirely in the runtime jar and opaque to connectors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)