You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/19 17:19:11 UTC

[GitHub] [kafka] jsancio opened a new pull request #10363: MINOR: Assume unclean shutdown for metadata log

jsancio opened a new pull request #10363:
URL: https://github.com/apache/kafka/pull/10363


   Since log recovery for the metadata log is not implemented at the moment
   always assume that the replica was shutdown uncleanly. This is okay to because:
   
   1. Snapshots are not fully implemented for the metadata log
   2. The replicas (controllers and brokers) need to read the entire metadata log to load it into memory.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] jsancio commented on pull request #10363: MINOR: Assume unclean shutdown for metadata log

Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #10363:
URL: https://github.com/apache/kafka/pull/10363#issuecomment-802991144


   We should cherry pick this to the 2.8 branch. cc @vvcephei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] hachikuji merged pull request #10363: MINOR: Assume unclean shutdown for metadata log

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10363:
URL: https://github.com/apache/kafka/pull/10363


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org