You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/08 04:27:09 UTC
[GitHub] [flink] wsry opened a new pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
wsry opened a new pull request #12513:
URL: https://github.com/apache/flink/pull/12513
## What is the purpose of the change
Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
## Brief change log
- Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
## Verifying this change
This change is a trivial rework.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12513:
URL: https://github.com/apache/flink/pull/12513#issuecomment-640366598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e521cd6f062cda3eb3b02cec6c27aefcd36e65b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2896",
"triggerID" : "e521cd6f062cda3eb3b02cec6c27aefcd36e65b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e521cd6f062cda3eb3b02cec6c27aefcd36e65b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #12513:
URL: https://github.com/apache/flink/pull/12513#discussion_r437277337
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
##########
@@ -1294,6 +1294,10 @@ static void submitTasksAndWaitForResults(ExecutorService executor, Callable[] ta
for (Future result : results) {
result.get();
}
+
+ // wait until the internal channel state recover task finishes
+ executor.shutdown();
Review comment:
This util is widely used in many tests and every caller will also shutdown it in finally region.
So it is better not shutdown it in this common place to avoid this executor has some other usages afterwards.
We can verify the results in finally region after executor shutdown in this specific unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12513:
URL: https://github.com/apache/flink/pull/12513#issuecomment-640359762
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e521cd6f062cda3eb3b02cec6c27aefcd36e65b6 (Mon Jun 08 04:30:24 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12513:
URL: https://github.com/apache/flink/pull/12513#issuecomment-640366598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e521cd6f062cda3eb3b02cec6c27aefcd36e65b6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2896",
"triggerID" : "e521cd6f062cda3eb3b02cec6c27aefcd36e65b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e521cd6f062cda3eb3b02cec6c27aefcd36e65b6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12513:
URL: https://github.com/apache/flink/pull/12513#issuecomment-640366598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12513:
URL: https://github.com/apache/flink/pull/12513#issuecomment-640366598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e521cd6f062cda3eb3b02cec6c27aefcd36e65b6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e521cd6f062cda3eb3b02cec6c27aefcd36e65b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e521cd6f062cda3eb3b02cec6c27aefcd36e65b6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW merged pull request #12513: [FLINK-18057][tests] Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #12513:
URL: https://github.com/apache/flink/pull/12513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org