[GitHub] [accumulo] brianloss commented on a change in pull request #2023: Use builtin immutable maps/sets/lists when available

[GitBox <gi...@apache.org>]

brianloss commented on a change in pull request #2023:
URL: https://github.com/apache/accumulo/pull/2023#discussion_r614011130



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
##########
@@ -1189,11 +1186,10 @@ boolean canSuspendTablets() {
     ThreadPools.createGeneralScheduledExecutorService(getConfiguration())
         .scheduleWithFixedDelay(() -> {
           try {
-            if (replServer.get() == null) {
-              if (!getConfiguration().get(Property.REPLICATION_NAME).isEmpty()) {
-                log.info(Property.REPLICATION_NAME.getKey() + " was set, starting repl services.");
-                replServer.set(setupReplication());
-              }
+            if ((replServer.get() == null)
+                && !getConfiguration().get(Property.REPLICATION_NAME).isEmpty()) {
+              log.info(Property.REPLICATION_NAME.getKey() + " was set, starting repl services.");

Review comment:
       ```suggestion
                 log.info("{} was set, starting repl services.", Property.REPLICATION_NAME.getKey());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org