[GitHub] [zeppelin] saLeox opened a new pull request, #4353: [ZEPPELIN-5717] Fix incorrect editor value gotten by Runner

[GitBox <gi...@apache.org>]

saLeox opened a new pull request, #4353:
URL: https://github.com/apache/zeppelin/pull/4353

   ### What is this PR for?
   For user under runner role, the editor is hidden, so the $scope.editor object is not empty and the $scope.editor.getValue() function may return a null value.
   
   So there should be one more condition to judge: if user cannot view editor, it's also expected to get editor value from $scope.paragraph.text as well.
   
   ### What type of PR is it?
   Bug Fix 
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/5717
   
   ### How should this be tested?
   * Create paragraph with input box in notebook;
   * Grant one user with only runner role;
   * Login and run the paragraph by pressing the enter key on input box(can try multiple times);
   * See if the paragraph content will be overwritten and lost (become empty);
   * If no, means success.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul merged pull request #4353: [ZEPPELIN-5717] Fix incorrect editor value gotten by Runner

[GitBox <gi...@apache.org>]

jongyoul merged PR #4353:
URL: https://github.com/apache/zeppelin/pull/4353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org