You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/07/16 20:24:31 UTC

[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1189
  
    Thanks for contribution!
    
    `ZEPPELIN_JAVA_OPTS` used to set JVM options both ZeppelinServer and InterpreterProcess.
    Later `ZEPPELIN_INTP_JAVA_OPTS` has been introduced. To keep compatibility with previous configuration, `ZEPPELIN_INTP_JAVA_OPTS` designed to overrides `ZEPPELIN_JAVA_OPTS` for InterpreterProcess.
    So previous version of `conf/zeppelin-env.sh` can work without modification. 
    That's why InterpreterProcess looks like implicitly uses `ZEPPELIN_JAVA_OPTS`.
    
    I don't have any preference of either keeping current behavior or change it.
    
    But if you'd like to change, I think `ZEPPELIN_INTP_MEM` also need to be changed, to make configuration consistent.
    
    Also, this change makes `conf/zeppelin-env.sh` incompatible to previous version. So i think it's great idea that guide user how `ZEPPELIN_JAVA_OPTS` and `ZEPPELIN_INTP_JAVA_OPTS` are changed through https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---