You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by do...@apache.org on 2018/03/10 01:33:26 UTC
[17/28] reef git commit: [REEF-1958] Set logging level to Verbose in
all processes of HelloREEF example
[REEF-1958] Set logging level to Verbose in all processes of HelloREEF example
Set logging level to `Verbose` in HelloREEF (local and YARN versions)
for the Driver and the Evaluators
+ better logging and some cleanup in the HelloREEF C# driver to make
sure that setting logging levels works properly
JIRA:
[REEF-1958](https://issues.apache.org/jira/browse/REEF-1958)
Pull Request:
This closes #1417
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/821ef2a2
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/821ef2a2
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/821ef2a2
Branch: refs/heads/REEF-335
Commit: 821ef2a2206b4b615d0289b655d57c259196b653
Parents: aeb730a
Author: Sergiy Matusevych <mo...@apache.org>
Authored: Fri Nov 10 16:31:32 2017 -0800
Committer: Markus Weimer <we...@apache.org>
Committed: Tue Nov 14 10:12:00 2017 -0800
----------------------------------------------------------------------
.../Org.Apache.REEF.Examples.HelloREEF/HelloDriver.cs | 12 ++++++++----
.../cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEF.cs | 5 +++--
.../HelloREEFYarn.cs | 13 +++++++------
3 files changed, 18 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/821ef2a2/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloDriver.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloDriver.cs b/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloDriver.cs
index fbac3d0..2a0a8da 100644
--- a/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloDriver.cs
+++ b/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloDriver.cs
@@ -42,13 +42,17 @@ namespace Org.Apache.REEF.Examples.HelloREEF
/// <summary>
/// Submits the HelloTask to the Evaluator.
/// </summary>
- /// <param name="allocatedEvaluator"></param>
+ /// <param name="allocatedEvaluator">Newly allocated evaluator's proxy object.</param>
public void OnNext(IAllocatedEvaluator allocatedEvaluator)
{
+ _Logger.Log(Level.Info, "Evaluator allocated: {0}", allocatedEvaluator);
+
var taskConfiguration = TaskConfiguration.ConfigurationModule
.Set(TaskConfiguration.Identifier, "HelloTask")
.Set(TaskConfiguration.Task, GenericType<HelloTask>.Class)
.Build();
+
+ _Logger.Log(Level.Verbose, "Submit task: {0}", taskConfiguration);
allocatedEvaluator.SubmitTask(taskConfiguration);
}
@@ -62,12 +66,12 @@ namespace Org.Apache.REEF.Examples.HelloREEF
}
/// <summary>
- /// Called to start the user mode driver
+ /// Called to start the user mode driver.
/// </summary>
- /// <param name="driverStarted"></param>
+ /// <param name="driverStarted">Notification that the Driver is up and running.</param>
public void OnNext(IDriverStarted driverStarted)
{
- _Logger.Log(Level.Info, string.Format("HelloDriver started at {0}", driverStarted.StartTime));
+ _Logger.Log(Level.Info, "HelloDriver started at {0}", driverStarted.StartTime);
_evaluatorRequestor.Submit(_evaluatorRequestor.NewBuilder().SetMegabytes(64).Build());
}
}
http://git-wip-us.apache.org/repos/asf/reef/blob/821ef2a2/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEF.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEF.cs b/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEF.cs
index e29ea0c..8f9053d 100644
--- a/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEF.cs
+++ b/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEF.cs
@@ -57,6 +57,7 @@ namespace Org.Apache.REEF.Examples.HelloREEF
var helloDriverConfiguration = DriverConfiguration.ConfigurationModule
.Set(DriverConfiguration.OnEvaluatorAllocated, GenericType<HelloDriver>.Class)
.Set(DriverConfiguration.OnDriverStarted, GenericType<HelloDriver>.Class)
+ .Set(DriverConfiguration.CustomTraceLevel, Level.Verbose.ToString())
.Build();
// The JobSubmission contains the Driver configuration as well as the files needed on the Driver.
@@ -91,7 +92,7 @@ namespace Org.Apache.REEF.Examples.HelloREEF
return YARNClientConfiguration.ConfigurationModuleYARNRest.Build();
case HDInsight:
// To run against HDInsight please replace placeholders below, with actual values for
- // connection string, container name (available at Azure portal) and HDInsight
+ // connection string, container name (available at Azure portal) and HDInsight
// credentials (username and password)
const string connectionString = "ConnString";
const string continerName = "foo";
@@ -112,4 +113,4 @@ namespace Org.Apache.REEF.Examples.HelloREEF
TangFactory.GetTang().NewInjector(GetRuntimeConfiguration(args.Length > 0 ? args[0] : Local)).GetInstance<HelloREEF>().Run();
}
}
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/reef/blob/821ef2a2/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEFYarn.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEFYarn.cs b/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEFYarn.cs
index e7dfcf0..754de62 100644
--- a/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEFYarn.cs
+++ b/lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEFYarn.cs
@@ -61,7 +61,7 @@ namespace Org.Apache.REEF.Examples.HelloREEF
private readonly IList<string> _nodeNames;
[Inject]
- private HelloREEFYarn(IYarnREEFClient reefClient,
+ private HelloREEFYarn(IYarnREEFClient reefClient,
JobRequestBuilder jobRequestBuilder,
[Parameter(typeof(NodeNames))] ISet<string> nodeNames)
{
@@ -78,7 +78,8 @@ namespace Org.Apache.REEF.Examples.HelloREEF
// The driver configuration contains all the needed handler bindings
var helloDriverConfiguration = DriverConfiguration.ConfigurationModule
.Set(DriverConfiguration.OnEvaluatorAllocated, GenericType<HelloDriverYarn>.Class)
- .Set(DriverConfiguration.OnDriverStarted, GenericType<HelloDriverYarn>.Class)
+ .Set(DriverConfiguration.OnDriverStarted, GenericType<HelloDriverYarn>.Class)
+ .Set(DriverConfiguration.CustomTraceLevel, Level.Verbose.ToString())
.Build();
var driverConfig = TangFactory.GetTang()
@@ -88,7 +89,7 @@ namespace Org.Apache.REEF.Examples.HelloREEF
{
driverConfig.BindSetEntry<NodeNames, string>(GenericType<NodeNames>.Class, n);
}
-
+
// The JobSubmission contains the Driver configuration as well as the files needed on the Driver.
var helloJobRequest = _jobRequestBuilder
.AddDriverConfiguration(driverConfig.Build())
@@ -133,8 +134,8 @@ namespace Org.Apache.REEF.Examples.HelloREEF
}
else
{
- Logger.Log(Level.Info,
- "Failed to kill application {0}, possible reasons are application id is invalid or application has completed.",
+ Logger.Log(Level.Info,
+ "Failed to kill application {0}, possible reasons are application id is invalid or application has completed.",
appId);
}
}
@@ -200,4 +201,4 @@ namespace Org.Apache.REEF.Examples.HelloREEF
TangFactory.GetTang().NewInjector(configBuilder.Build()).GetInstance<HelloREEFYarn>().Run();
}
}
-}
\ No newline at end of file
+}