You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/07/15 06:59:54 UTC
Re: Review Request 35084: Provided consistent behavior for bundled
packages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
-----------------------------------------------------------
(Updated July 15, 2015, 4:59 a.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
Bugs: MESOS-2537
https://issues.apache.org/jira/browse/MESOS-2537
Repository: mesos
Description
-------
Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.
The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.
Diffs (updated)
-----
configure.ac cad7f0e92eacc86d37b3f578382946db8b466531
Diff: https://reviews.apache.org/r/35084/diff/
Testing
-------
Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not exhaustive!) combinations of enabling and disableing bundled packages.
For example, on CentOS, this alost works:
$ onfigure.developer --disable-bundled --with-zookeeper=bundled --with-gmock=bundled
To work completely, this change needs to be propagated to libprocess, which I can do once reviewers agree that it's the right behavior.
Thanks,
James Peach
Re: Review Request 35084: Provide consistent behavior for bundled
packages.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review97566
-----------------------------------------------------------
Overall I believe this makes sense, I'll need some more time to test this out (I'm on OS X 10.10.5), but +1 for consistency!
- Joe Smith
On Aug. 26, 2015, 1:18 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35084/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 1:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
>
>
> Bugs: MESOS-2537
> https://issues.apache.org/jira/browse/MESOS-2537
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
> consistent behavior for bundled packages selected by either
> --enable-bundled-$PACKAGE or --with-$PACKAGE.
>
> The default policy is set by --enable-bundled and overridden when
> the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
> option. If --with-$PACKAGE is specified as "bundled", the bundled
> version is selected.
>
>
> Diffs
> -----
>
> configure.ac 87461d73ed04c4cf176c3475ded9f98dadcda608
>
> Diff: https://reviews.apache.org/r/35084/diff/
>
>
> Testing
> -------
>
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not exhaustive!) combinations of enabling and disabling bundled packages.
>
> For example, on CentOS, this alost works:
> $ onfigure.developer --disable-bundled --with-zookeeper=bundled --with-gmock=bundled
>
> To work completely, this change needs to be propagated to libprocess, which I can do once reviewers agree that it's the right behavior.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 35084: Provide consistent behavior for bundled
packages.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 8:18 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
Summary (updated)
-----------------
Provide consistent behavior for bundled packages.
Bugs: MESOS-2537
https://issues.apache.org/jira/browse/MESOS-2537
Repository: mesos
Description
-------
Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.
The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.
Diffs
-----
configure.ac 87461d73ed04c4cf176c3475ded9f98dadcda608
Diff: https://reviews.apache.org/r/35084/diff/
Testing (updated)
-------
Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not exhaustive!) combinations of enabling and disabling bundled packages.
For example, on CentOS, this alost works:
$ onfigure.developer --disable-bundled --with-zookeeper=bundled --with-gmock=bundled
To work completely, this change needs to be propagated to libprocess, which I can do once reviewers agree that it's the right behavior.
Thanks,
James Peach
Re: Review Request 35084: Provided consistent behavior for bundled
packages.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 8:10 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
Changes
-------
Rebased.
Bugs: MESOS-2537
https://issues.apache.org/jira/browse/MESOS-2537
Repository: mesos
Description
-------
Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.
The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.
Diffs (updated)
-----
configure.ac 87461d73ed04c4cf176c3475ded9f98dadcda608
Diff: https://reviews.apache.org/r/35084/diff/
Testing
-------
Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not exhaustive!) combinations of enabling and disableing bundled packages.
For example, on CentOS, this alost works:
$ onfigure.developer --disable-bundled --with-zookeeper=bundled --with-gmock=bundled
To work completely, this change needs to be propagated to libprocess, which I can do once reviewers agree that it's the right behavior.
Thanks,
James Peach