You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by Craig Rueda <cr...@craigrueda.com> on 2020/02/18 15:22:35 UTC

Re: [VOTE] [SIP-26] Proposal for`Implementing Connection Pooling for Analytics Database Connections

+1 binding

- Craig

> On Feb 17, 2020, at 9:46 PM, Grace Guo <gr...@airbnb.com.invalid> wrote:
> 
> +1 binding
> 
> - Grace
> 
>> On Feb 14, 2020, at 2:41 PM, Maxime Beauchemin <ma...@gmail.com> wrote:
>> 
>> Superset Community,
>> 
>> This is a call to vote for SIP-26 Proposal for Implementing Connection
>> Pooling for Analytics Database Connections
>> 
>> Further details here:
>> https://github.com/apache/incubator-superset/issues/8574
>> 
>> The vote will be open for at least 1 Week or until the necessary number of
>> votes are reached.
>> 
>> Please vote accordingly:
>> 
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>> 
>> Thanks!
>> 
>> Max
> 

Re: [VOTE] [SIP-26] Proposal for Implementing Connection Pooling for Analytics Database Connections

Posted by William Barrett <wi...@preset.io>.
That’s fine. I’ve had issues with emails not going through to the list - the [DISCUSS] message appears to have been one that didn’t make it. Let’s consider this the discussion thread then and we’ll re-trigger in a few days.

Will Barrett
Staff Software Engineer
Preset, Inc. | https://preset.io
On Feb 18, 2020, 11:23 AM -0800, Erik Ritter <er...@gmail.com>, wrote:
> -1 (non binding)
>
> It appears that this SIP did not have a [DISCUSS] email sent to the dev
> list (see mailing list history here:
> https://lists.apache.org/list.html?dev@superset.apache.org:lte=1y:SIP-26),
> so I'm concerned that everyone who wanted to provide feedback didn't get a
> chance. Could we make this the [DISCUSS] thread then revote a week from now?
>
> Thanks,
> Erik
>
> On Tue, Feb 18, 2020 at 7:22 AM Craig Rueda <cr...@craigrueda.com> wrote:
>
> > +1 binding
> >
> > - Craig
> >
> > > On Feb 17, 2020, at 9:46 PM, Grace Guo <gr...@airbnb.com.invalid>
> > wrote:
> > >
> > > +1 binding
> > >
> > > - Grace
> > >
> > > > On Feb 14, 2020, at 2:41 PM, Maxime Beauchemin <
> > maximebeauchemin@gmail.com> wrote:
> > > >
> > > > Superset Community,
> > > >
> > > > This is a call to vote for SIP-26 Proposal for Implementing Connection
> > > > Pooling for Analytics Database Connections
> > > >
> > > > Further details here:
> > > > https://github.com/apache/incubator-superset/issues/8574
> > > >
> > > > The vote will be open for at least 1 Week or until the necessary number
> > of
> > > > votes are reached.
> > > >
> > > > Please vote accordingly:
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > Thanks!
> > > >
> > > > Max
> > >
> >

Re: Re: [VOTE] [SIP-26] Proposal for Implementing Connection Pooling for Analytics Database Connections

Posted by Maxime Beauchemin <ma...@gmail.com>.
Yes, sorry I thought we had sent the [DISCUSS] notice pointing to the
Github issue a while back.

The SIP process is well documented in SIP-0
<https://github.com/apache/incubator-superset/issues/5602> and we're
supposed to send a [DISCUSS] notice to dev@ prior to the vote.

Let's revive the conversation in the Github issue and re-kick off a fresh
vote in ~a week.

Max

On Tue, Feb 18, 2020 at 2:16 PM Erik Ritter <er...@airbnb.com.invalid>
wrote:

> I think discussion occurring in the Github issue is ideal. However, as I
> (and many others) don't often view notifications from issues being created,
> we depend on the [DISCUSS] email to alert us to a new SIP being created.
>
> Erik
>
> On Tue, Feb 18, 2020 at 1:57 PM Brannon, Terrence
> <te...@usbank.com.invalid> wrote:
>
> > It seems that discussion also occurs in the github issue itself:
> > https://github.com/apache/incubator-superset/issues/8574
> >
> > Do you desire a single place of discussion? Or is it OK for discussion to
> > occur in the github ticket as well the dev-list?
> >
> > -----Original Message-----
> > From: Erik Ritter <er...@gmail.com>
> > Sent: Tuesday, February 18, 2020 11:23 AM
> > To: dev@superset.incubator.apache.org
> > Cc: dev@superset.apache.org
> > Subject: [EXTERNAL] Re: [VOTE] [SIP-26] Proposal for Implementing
> > Connection Pooling for Analytics Database Connections
> >
> > -1 (non binding)
> >
> > It appears that this SIP did not have a [DISCUSS] email sent to the dev
> > list (see mailing list history here:
> >
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.apache.org_list.html-3Fdev-40superset.apache.org-3Alte-3D1y-3ASIP-2D26&d=DwIFaQ&c=1hIq-C3ayh4zm6RZ7m4R2A&r=YFv754w0-1hOQn5jCB3GpLIc7nupwqAk7x9jHnHpUVw&m=E8BZqaFzEwFAZ1PA2nZUTav7ln9yEwst8LDPhLoYO8M&s=Yxfh76rdED68gjVEHvvclUe0AEa7-Mlsq5d_DkAwpYM&e=
> > ), so I'm concerned that everyone who wanted to provide feedback didn't
> get
> > a chance. Could we make this the [DISCUSS] thread then revote a week from
> > now?
> >
> > Thanks,
> > Erik
> >
> > On Tue, Feb 18, 2020 at 7:22 AM Craig Rueda <cr...@craigrueda.com>
> wrote:
> >
> > > +1 binding
> > >
> > > - Craig
> > >
> > > > On Feb 17, 2020, at 9:46 PM, Grace Guo
> > > > <gr...@airbnb.com.invalid>
> > > wrote:
> > > >
> > > > +1 binding
> > > >
> > > > - Grace
> > > >
> > > >> On Feb 14, 2020, at 2:41 PM, Maxime Beauchemin <
> > > maximebeauchemin@gmail.com> wrote:
> > > >>
> > > >> Superset Community,
> > > >>
> > > >> This is a call to vote for SIP-26 Proposal for Implementing
> > > >> Connection Pooling for Analytics Database Connections
> > > >>
> > > >> Further details here:
> > > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apa
> > > >> che_incubator-2Dsuperset_issues_8574&d=DwIFaQ&c=1hIq-C3ayh4zm6RZ7m4
> > > >> R2A&r=YFv754w0-1hOQn5jCB3GpLIc7nupwqAk7x9jHnHpUVw&m=E8BZqaFzEwFAZ1P
> > > >> A2nZUTav7ln9yEwst8LDPhLoYO8M&s=USx_1rKoin5B7pP1oQ3gJxRAj3D7fowah4AT
> > > >> veNYt1s&e=
> > > >>
> > > >> The vote will be open for at least 1 Week or until the necessary
> > > >> number
> > > of
> > > >> votes are reached.
> > > >>
> > > >> Please vote accordingly:
> > > >>
> > > >> [ ] +1 approve
> > > >> [ ] +0 no opinion
> > > >> [ ] -1 disapprove with the reason
> > > >>
> > > >> Thanks!
> > > >>
> > > >> Max
> > > >
> > >
> >
> >
> > U.S. BANCORP made the following annotations
> > ---------------------------------------------------------------------
> > Electronic Privacy Notice. This e-mail, and any attachments, contains
> > information that is, or may be, covered by electronic communications
> > privacy laws, and is also confidential and proprietary in nature. If you
> > are not the intended recipient, please be advised that you are legally
> > prohibited from retaining, using, copying, distributing, or otherwise
> > disclosing this information in any manner. Instead, please reply to the
> > sender that you have received this communication in error, and then
> > immediately delete it. Thank you in advance for your cooperation.
> >
> > ---------------------------------------------------------------------
> >
>

Re: Re: [VOTE] [SIP-26] Proposal for Implementing Connection Pooling for Analytics Database Connections

Posted by Erik Ritter <er...@airbnb.com.INVALID>.
I think discussion occurring in the Github issue is ideal. However, as I
(and many others) don't often view notifications from issues being created,
we depend on the [DISCUSS] email to alert us to a new SIP being created.

Erik

On Tue, Feb 18, 2020 at 1:57 PM Brannon, Terrence
<te...@usbank.com.invalid> wrote:

> It seems that discussion also occurs in the github issue itself:
> https://github.com/apache/incubator-superset/issues/8574
>
> Do you desire a single place of discussion? Or is it OK for discussion to
> occur in the github ticket as well the dev-list?
>
> -----Original Message-----
> From: Erik Ritter <er...@gmail.com>
> Sent: Tuesday, February 18, 2020 11:23 AM
> To: dev@superset.incubator.apache.org
> Cc: dev@superset.apache.org
> Subject: [EXTERNAL] Re: [VOTE] [SIP-26] Proposal for Implementing
> Connection Pooling for Analytics Database Connections
>
> -1 (non binding)
>
> It appears that this SIP did not have a [DISCUSS] email sent to the dev
> list (see mailing list history here:
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.apache.org_list.html-3Fdev-40superset.apache.org-3Alte-3D1y-3ASIP-2D26&d=DwIFaQ&c=1hIq-C3ayh4zm6RZ7m4R2A&r=YFv754w0-1hOQn5jCB3GpLIc7nupwqAk7x9jHnHpUVw&m=E8BZqaFzEwFAZ1PA2nZUTav7ln9yEwst8LDPhLoYO8M&s=Yxfh76rdED68gjVEHvvclUe0AEa7-Mlsq5d_DkAwpYM&e=
> ), so I'm concerned that everyone who wanted to provide feedback didn't get
> a chance. Could we make this the [DISCUSS] thread then revote a week from
> now?
>
> Thanks,
> Erik
>
> On Tue, Feb 18, 2020 at 7:22 AM Craig Rueda <cr...@craigrueda.com> wrote:
>
> > +1 binding
> >
> > - Craig
> >
> > > On Feb 17, 2020, at 9:46 PM, Grace Guo
> > > <gr...@airbnb.com.invalid>
> > wrote:
> > >
> > > +1 binding
> > >
> > > - Grace
> > >
> > >> On Feb 14, 2020, at 2:41 PM, Maxime Beauchemin <
> > maximebeauchemin@gmail.com> wrote:
> > >>
> > >> Superset Community,
> > >>
> > >> This is a call to vote for SIP-26 Proposal for Implementing
> > >> Connection Pooling for Analytics Database Connections
> > >>
> > >> Further details here:
> > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apa
> > >> che_incubator-2Dsuperset_issues_8574&d=DwIFaQ&c=1hIq-C3ayh4zm6RZ7m4
> > >> R2A&r=YFv754w0-1hOQn5jCB3GpLIc7nupwqAk7x9jHnHpUVw&m=E8BZqaFzEwFAZ1P
> > >> A2nZUTav7ln9yEwst8LDPhLoYO8M&s=USx_1rKoin5B7pP1oQ3gJxRAj3D7fowah4AT
> > >> veNYt1s&e=
> > >>
> > >> The vote will be open for at least 1 Week or until the necessary
> > >> number
> > of
> > >> votes are reached.
> > >>
> > >> Please vote accordingly:
> > >>
> > >> [ ] +1 approve
> > >> [ ] +0 no opinion
> > >> [ ] -1 disapprove with the reason
> > >>
> > >> Thanks!
> > >>
> > >> Max
> > >
> >
>
>
> U.S. BANCORP made the following annotations
> ---------------------------------------------------------------------
> Electronic Privacy Notice. This e-mail, and any attachments, contains
> information that is, or may be, covered by electronic communications
> privacy laws, and is also confidential and proprietary in nature. If you
> are not the intended recipient, please be advised that you are legally
> prohibited from retaining, using, copying, distributing, or otherwise
> disclosing this information in any manner. Instead, please reply to the
> sender that you have received this communication in error, and then
> immediately delete it. Thank you in advance for your cooperation.
>
> ---------------------------------------------------------------------
>

RE: Re: [VOTE] [SIP-26] Proposal for Implementing Connection Pooling for Analytics Database Connections

Posted by "Brannon, Terrence" <te...@usbank.com.INVALID>.
It seems that discussion also occurs in the github issue itself:
https://github.com/apache/incubator-superset/issues/8574

Do you desire a single place of discussion? Or is it OK for discussion to occur in the github ticket as well the dev-list?

-----Original Message-----
From: Erik Ritter <er...@gmail.com> 
Sent: Tuesday, February 18, 2020 11:23 AM
To: dev@superset.incubator.apache.org
Cc: dev@superset.apache.org
Subject: [EXTERNAL] Re: [VOTE] [SIP-26] Proposal for Implementing Connection Pooling for Analytics Database Connections

-1 (non binding)

It appears that this SIP did not have a [DISCUSS] email sent to the dev list (see mailing list history here:
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.apache.org_list.html-3Fdev-40superset.apache.org-3Alte-3D1y-3ASIP-2D26&d=DwIFaQ&c=1hIq-C3ayh4zm6RZ7m4R2A&r=YFv754w0-1hOQn5jCB3GpLIc7nupwqAk7x9jHnHpUVw&m=E8BZqaFzEwFAZ1PA2nZUTav7ln9yEwst8LDPhLoYO8M&s=Yxfh76rdED68gjVEHvvclUe0AEa7-Mlsq5d_DkAwpYM&e= ), so I'm concerned that everyone who wanted to provide feedback didn't get a chance. Could we make this the [DISCUSS] thread then revote a week from now?

Thanks,
Erik

On Tue, Feb 18, 2020 at 7:22 AM Craig Rueda <cr...@craigrueda.com> wrote:

> +1 binding
>
> - Craig
>
> > On Feb 17, 2020, at 9:46 PM, Grace Guo 
> > <gr...@airbnb.com.invalid>
> wrote:
> >
> > +1 binding
> >
> > - Grace
> >
> >> On Feb 14, 2020, at 2:41 PM, Maxime Beauchemin <
> maximebeauchemin@gmail.com> wrote:
> >>
> >> Superset Community,
> >>
> >> This is a call to vote for SIP-26 Proposal for Implementing 
> >> Connection Pooling for Analytics Database Connections
> >>
> >> Further details here:
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apa
> >> che_incubator-2Dsuperset_issues_8574&d=DwIFaQ&c=1hIq-C3ayh4zm6RZ7m4
> >> R2A&r=YFv754w0-1hOQn5jCB3GpLIc7nupwqAk7x9jHnHpUVw&m=E8BZqaFzEwFAZ1P
> >> A2nZUTav7ln9yEwst8LDPhLoYO8M&s=USx_1rKoin5B7pP1oQ3gJxRAj3D7fowah4AT
> >> veNYt1s&e=
> >>
> >> The vote will be open for at least 1 Week or until the necessary 
> >> number
> of
> >> votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thanks!
> >>
> >> Max
> >
>


U.S. BANCORP made the following annotations
---------------------------------------------------------------------
Electronic Privacy Notice. This e-mail, and any attachments, contains information that is, or may be, covered by electronic communications privacy laws, and is also confidential and proprietary in nature. If you are not the intended recipient, please be advised that you are legally prohibited from retaining, using, copying, distributing, or otherwise disclosing this information in any manner. Instead, please reply to the sender that you have received this communication in error, and then immediately delete it. Thank you in advance for your cooperation.

---------------------------------------------------------------------

Re: [VOTE] [SIP-26] Proposal for Implementing Connection Pooling for Analytics Database Connections

Posted by Erik Ritter <er...@gmail.com>.
-1 (non binding)

It appears that this SIP did not have a [DISCUSS] email sent to the dev
list (see mailing list history here:
https://lists.apache.org/list.html?dev@superset.apache.org:lte=1y:SIP-26),
so I'm concerned that everyone who wanted to provide feedback didn't get a
chance. Could we make this the [DISCUSS] thread then revote a week from now?

Thanks,
Erik

On Tue, Feb 18, 2020 at 7:22 AM Craig Rueda <cr...@craigrueda.com> wrote:

> +1 binding
>
> - Craig
>
> > On Feb 17, 2020, at 9:46 PM, Grace Guo <gr...@airbnb.com.invalid>
> wrote:
> >
> > +1 binding
> >
> > - Grace
> >
> >> On Feb 14, 2020, at 2:41 PM, Maxime Beauchemin <
> maximebeauchemin@gmail.com> wrote:
> >>
> >> Superset Community,
> >>
> >> This is a call to vote for SIP-26 Proposal for Implementing Connection
> >> Pooling for Analytics Database Connections
> >>
> >> Further details here:
> >> https://github.com/apache/incubator-superset/issues/8574
> >>
> >> The vote will be open for at least 1 Week or until the necessary number
> of
> >> votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thanks!
> >>
> >> Max
> >
>