You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/31 02:30:32 UTC

[GitHub] [skywalking] kezhenxu94 commented on issue #4152: [Feature] Add tag annotation to allow tagging span with annotation

kezhenxu94 commented on issue #4152: [Feature] Add tag annotation to allow tagging span with annotation
URL: https://github.com/apache/skywalking/pull/4152#issuecomment-569850311
 
 
   > Does this PR support we can using anntation write our agent plugins ?
   
   Do you mean using `@Tag` in the agent plugin methods? No you can't, classes of agent plugins are ignored:
   
   https://github.com/apache/skywalking/blob/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15/apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java#L90-L98
   
   so although you can annotate the plugin method with `@Tag`, it takes no effect

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services