[GitHub] [iceberg] zhongyujiang commented on a diff in pull request #6517: Parquet: Fixes Incorrect Skipping of RowGroups with NaNs

[GitBox <gi...@apache.org>]

zhongyujiang commented on code in PR #6517:
URL: https://github.com/apache/iceberg/pull/6517#discussion_r1061447313


##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -580,6 +608,10 @@ static boolean hasNonNullButNoMinMax(Statistics statistics, long valueCount) {
         && (statistics.getMaxBytes() == null || statistics.getMinBytes() == null);
   }
 
+  static boolean minMaxUndefined(Statistics statistics) {
+    return !statistics.isEmpty() && !statistics.hasNonNullValue();

Review Comment:
   This [unit test](https://github.com/apache/iceberg/issues/6516#issuecomment-1370862183) fails, I think it's because when all values are all null , min max will be null(undefined) too, seems we should handle the case of all values first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org