You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zhengruifeng <gi...@git.apache.org> on 2017/12/19 09:58:12 UTC

[GitHub] spark pull request #20017: [SPARK-22832][ML] BisectingKMeans unpersist unuse...

GitHub user zhengruifeng opened a pull request:

    https://github.com/apache/spark/pull/20017

    [SPARK-22832][ML] BisectingKMeans unpersist unused datasets

    ## What changes were proposed in this pull request?
    unpersist unused datasets
    
    ## How was this patch tested?
    existing tests and local check in Spark-Shell

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhengruifeng/spark bkm_unpersist

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20017
    
----
commit 4e0d26653f3828219a7ac0b053f11faa44d6cdb1
Author: Zheng RuiFeng <ru...@foxmail.com>
Date:   2017-12-19T09:33:49Z

    create pr

commit e05cc267d9246e6ba662bfb882bfb5864600fb2b
Author: Zheng RuiFeng <ru...@foxmail.com>
Date:   2017-12-19T09:47:18Z

    lint

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85144/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    **[Test build #85144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85144/testReport)** for PR 20017 at commit [`3767e80`](https://github.com/apache/spark/commit/3767e805a981a0442378e110e1049b5e0efa6a54).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20017: [SPARK-22832][ML] BisectingKMeans unpersist unuse...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20017#discussion_r157757018
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
    @@ -212,7 +212,9 @@ class BisectingKMeans private (
           }
           level += 1
         }
    -    if(indices != null) indices.unpersist()
    +    if (preIndices != null) preIndices.unpersist(blocking = false)
    --- End diff --
    
    Do we usually write "blocking ="? there's only one argument.
    I'd use braces and put the body on the next line too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    Merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    **[Test build #85144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85144/testReport)** for PR 20017 at commit [`3767e80`](https://github.com/apache/spark/commit/3767e805a981a0442378e110e1049b5e0efa6a54).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    **[Test build #85104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85104/testReport)** for PR 20017 at commit [`e05cc26`](https://github.com/apache/spark/commit/e05cc267d9246e6ba662bfb882bfb5864600fb2b).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by zhengruifeng <gi...@git.apache.org>.
Github user zhengruifeng commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    ping @srowen 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    **[Test build #85104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85104/testReport)** for PR 20017 at commit [`e05cc26`](https://github.com/apache/spark/commit/e05cc267d9246e6ba662bfb882bfb5864600fb2b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20017: [SPARK-22832][ML] BisectingKMeans unpersist unuse...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20017


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20017: [SPARK-22832][ML] BisectingKMeans unpersist unused datas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20017
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85104/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org