You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (Created) (JIRA)" <ji...@apache.org> on 2012/02/01 06:50:58 UTC
[jira] [Created] (CASSANDRA-3823) [patch] remove bogus assert -
never false
[patch] remove bogus assert - never false
-----------------------------------------
Key: CASSANDRA-3823
URL: https://issues.apache.org/jira/browse/CASSANDRA-3823
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Dave Brosius
Priority: Trivial
Attachments: remove_bogus_assert.diff
code asserts that SSTableScanner is Closeable
final SSTableScanner scanner = sstable.getScanner(filter);
scanner.seekTo(startWith);
- assert scanner instanceof Closeable; // otherwise we leak FDs
always is, unless null, but of course the line before would throw NPE.
Just confusing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-3823) [patch] remove bogus assert -
never false
Posted by "Jonathan Ellis (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-3823.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.1
Reviewer: jbellis
Assignee: Dave Brosius
committed, thanks
> [patch] remove bogus assert - never false
> -----------------------------------------
>
> Key: CASSANDRA-3823
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3823
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: remove_bogus_assert.diff
>
>
> code asserts that SSTableScanner is Closeable
> final SSTableScanner scanner = sstable.getScanner(filter);
> scanner.seekTo(startWith);
> - assert scanner instanceof Closeable; // otherwise we leak FDs
> always is, unless null, but of course the line before would throw NPE.
> Just confusing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3823) [patch] remove bogus assert -
never false
Posted by "Dave Brosius (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated CASSANDRA-3823:
------------------------------------
Attachment: remove_bogus_assert.diff
> [patch] remove bogus assert - never false
> -----------------------------------------
>
> Key: CASSANDRA-3823
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3823
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: remove_bogus_assert.diff
>
>
> code asserts that SSTableScanner is Closeable
> final SSTableScanner scanner = sstable.getScanner(filter);
> scanner.seekTo(startWith);
> - assert scanner instanceof Closeable; // otherwise we leak FDs
> always is, unless null, but of course the line before would throw NPE.
> Just confusing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira