You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2020/05/25 04:21:00 UTC
[GitHub] [wicket] solomax opened a new pull request #434: [WICKET-6789] 'base-uri' is added to CSPDirective enum
solomax opened a new pull request #434:
URL: https://github.com/apache/wicket/pull/434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] papegaaij commented on a change in pull request #434: [WICKET-6789] 'base-uri' is added to CSPDirective enum
Posted by GitBox <gi...@apache.org>.
papegaaij commented on a change in pull request #434:
URL: https://github.com/apache/wicket/pull/434#discussion_r429758430
##########
File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPHeaderConfiguration.java
##########
@@ -99,7 +100,8 @@ public CSPHeaderConfiguration unsafeInline()
.add(CONNECT_SRC, SELF)
.add(FONT_SRC, SELF)
.add(MANIFEST_SRC, SELF)
- .add(CHILD_SRC, SELF);
+ .add(CHILD_SRC, SELF)
+ .add(BASE_URI, SELF);
Review comment:
The new directive should be added to the javadoc of this method as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax merged pull request #434: [WICKET-6789] 'base-uri' is added to CSPDirective enum
Posted by GitBox <gi...@apache.org>.
solomax merged pull request #434:
URL: https://github.com/apache/wicket/pull/434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax commented on a change in pull request #434: [WICKET-6789] 'base-uri' is added to CSPDirective enum
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #434:
URL: https://github.com/apache/wicket/pull/434#discussion_r429819914
##########
File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPHeaderConfiguration.java
##########
@@ -99,7 +100,8 @@ public CSPHeaderConfiguration unsafeInline()
.add(CONNECT_SRC, SELF)
.add(FONT_SRC, SELF)
.add(MANIFEST_SRC, SELF)
- .add(CHILD_SRC, SELF);
+ .add(CHILD_SRC, SELF)
+ .add(BASE_URI, SELF);
Review comment:
Should be addressed :)
Thanks for review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org