You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/26 06:07:32 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #11077: fix: surface connection error messages on the client
mistercrunch opened a new pull request #11077:
URL: https://github.com/apache/incubator-superset/pull/11077
### SUMMARY
I was trying to connect to BigQuery and was getting very generic error messages and nothing in the logs. The change here surfaces the good error handling done in the backend here:
https://github.com/apache/incubator-superset/blob/master/superset/databases/api.py#L576-L598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11077: fix: surface connection error messages on the client
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11077:
URL: https://github.com/apache/incubator-superset/pull/11077#discussion_r495464558
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -551,7 +552,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
checked={db ? !!db.impersonate_user : false}
onChange={onInputChange}
/>
- <div>{t('Impersonate Logged In User (Presto & Hive')}</div>
+ <div>{t('Impersonate Logged In User (Presto & Hive)')}</div>
Review comment:
unrelated typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #11077: fix: surface connection error messages on the client
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11077:
URL: https://github.com/apache/incubator-superset/pull/11077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org