You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/09 15:20:26 UTC

[GitHub] [airflow] suhanovv opened a new issue #17512: Invalid log order with ElasticsearchTaskHandler

suhanovv opened a new issue #17512:
URL: https://github.com/apache/airflow/issues/17512


   
   
   **Apache Airflow version**: 2.*
   
   **Apache Airflow Provider versions** (please include all providers that are relevant to your bug): providers-elasticsearch==1.*/2.*
   
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.17
   
   **What happened**:
   When using the ElasticsearchTaskHandler I see the broken order of the logs in the interface. 
   ![IMAGE 2021-08-09 18:05:13](https://user-images.githubusercontent.com/3032319/128728656-86736b50-4bd4-4178-9066-b70197b60421.jpg)
   
   **What you expected to happen**:
   
   The problem lies in the method [set_context](https://github.com/apache/airflow/blob/662cb8c6ac8becb26ff405f8b21acfccdd8de2ae/airflow/providers/elasticsearch/log/es_task_handler.py#L271) that is set on the instance of the class and then all entries in the log go with the same offset, which is used to select for display in the interface. When we redefined method emit and put the offset to the record, the problem disappeared
   
   
   **How to reproduce it**:
   Run a long-lived task that generates logs, in our case it is a spark task launched from a docker container
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] suhanovv commented on issue #17512: Invalid log order with ElasticsearchTaskHandler

Posted by GitBox <gi...@apache.org>.
suhanovv commented on issue #17512:
URL: https://github.com/apache/airflow/issues/17512#issuecomment-895321117


   yes, I will make a pull request 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] suhanovv commented on issue #17512: Invalid log order with ElasticsearchTaskHandler

Posted by GitBox <gi...@apache.org>.
suhanovv commented on issue #17512:
URL: https://github.com/apache/airflow/issues/17512#issuecomment-896973758


   @potiuk I made a PR, who can review it ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed issue #17512: Invalid log order with ElasticsearchTaskHandler

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #17512:
URL: https://github.com/apache/airflow/issues/17512


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #17512: Invalid log order with ElasticsearchTaskHandler

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17512:
URL: https://github.com/apache/airflow/issues/17512#issuecomment-895319116


   Would you be willing to provide a PR fixing.it (seems you already have the fix)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #17512: Invalid log order with ElasticsearchTaskHandler

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17512:
URL: https://github.com/apache/airflow/issues/17512#issuecomment-895314207


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #17512: Invalid log order with ElasticsearchTaskHandler

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17512:
URL: https://github.com/apache/airflow/issues/17512#issuecomment-898959741


   Closed by #17551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org