You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by bp...@apache.org on 2012/07/02 06:32:38 UTC
svn commit: r1356066 -
/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetCallableStatement.java
Author: bpendleton
Date: Mon Jul 2 04:32:38 2012
New Revision: 1356066
URL: http://svn.apache.org/viewvc?rev=1356066&view=rev
Log:
DERBY-5833: Remove unused methods in NetCallableStatement class
This patch was contributed by Mohamed Nufail (nufail56 at gmail dot com)
This change removes the following unused methods from the
NetCallableStatement class:
- resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
- resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
I suspect that, of the two remaining overloads of the resetNetCallableStatement
method, the 3-argument variant could be made private, as it is called only
by the 6-argument variant. That might be a further improvement we could do
at some future time. For now, this change simply removes the two variants
that are wholly unused.
Modified:
db/derby/code/trunk/java/client/org/apache/derby/client/net/NetCallableStatement.java
Modified: db/derby/code/trunk/java/client/org/apache/derby/client/net/NetCallableStatement.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetCallableStatement.java?rev=1356066&r1=1356065&r2=1356066&view=diff
==============================================================================
--- db/derby/code/trunk/java/client/org/apache/derby/client/net/NetCallableStatement.java (original)
+++ db/derby/code/trunk/java/client/org/apache/derby/client/net/NetCallableStatement.java Mon Jul 2 04:32:38 2012
@@ -91,22 +91,5 @@ public class NetCallableStatement extend
resetNetCallableStatement(callableStatement_, netAgent, netConnection);
}
- void resetNetCallableStatement(NetAgent netAgent,
- NetConnection netConnection,
- String sql,
- Section section) throws SqlException {
- callableStatement_.resetCallableStatement(netAgent, netConnection, sql, section);
- resetNetCallableStatement(callableStatement_, netAgent, netConnection);
- }
-
- void resetNetCallableStatement(NetAgent netAgent,
- NetConnection netConnection,
- String sql,
- Section section,
- ColumnMetaData parameterMetaData,
- ColumnMetaData resultSetMetaData) throws SqlException {
- callableStatement_.resetCallableStatement(netAgent, netConnection, sql, section, parameterMetaData, resultSetMetaData);
- resetNetCallableStatement(callableStatement_, netAgent, netConnection);
- }
}