You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/10/06 22:52:37 UTC
Review Request 52621: GEM-1032: GMSAuthenticator needs to get security
properties from system properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52621/
-----------------------------------------------------------
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* adding more tests
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java 8e4c15d4707ee6a6d48ab8be26a161e2a2660055
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java PRE-CREATION
geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/52621/diff/
Testing
-------
revert back to the old way of getting the security properties since this throws off some tests. Precheckin running
Thanks,
Jinmei Liao
Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get
security properties from system properties
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52621/#review151737
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Oct. 6, 2016, 11:03 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52621/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2016, 11:03 p.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * adding more tests
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java 8e4c15d4707ee6a6d48ab8be26a161e2a2660055
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithAuthenticatorTest.java c6cbf88c31362444f113785cdd217fdac8265461
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithSecurityManagerTest.java 49475e0c0296287405d43dfb9d29dcd8e45305d4
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52621/diff/
>
>
> Testing
> -------
>
> revert back to the old way of getting the security properties since this throws off some tests. Precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get
security properties from system properties
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52621/#review151742
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Oct. 6, 2016, 11:03 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52621/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2016, 11:03 p.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * adding more tests
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java 8e4c15d4707ee6a6d48ab8be26a161e2a2660055
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithAuthenticatorTest.java c6cbf88c31362444f113785cdd217fdac8265461
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithSecurityManagerTest.java 49475e0c0296287405d43dfb9d29dcd8e45305d4
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java PRE-CREATION
> geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52621/diff/
>
>
> Testing
> -------
>
> revert back to the old way of getting the security properties since this throws off some tests. Precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get
security properties from system properties
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52621/
-----------------------------------------------------------
(Updated Oct. 6, 2016, 11:03 p.m.)
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* adding more tests
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java 8e4c15d4707ee6a6d48ab8be26a161e2a2660055
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithAuthenticatorTest.java c6cbf88c31362444f113785cdd217fdac8265461
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithSecurityManagerTest.java 49475e0c0296287405d43dfb9d29dcd8e45305d4
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java PRE-CREATION
geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/52621/diff/
Testing
-------
revert back to the old way of getting the security properties since this throws off some tests. Precheckin running
Thanks,
Jinmei Liao