You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/08/16 18:11:07 UTC

[GitHub] dubeejw commented on a change in pull request #2463: Correct unable to set apihost issue.

dubeejw commented on a change in pull request #2463: Correct unable to set apihost issue.
URL: https://github.com/apache/incubator-openwhisk/pull/2463#discussion_r133525332
 
 

 ##########
 File path: tools/cli/go-whisk-cli/commands/util.go
 ##########
 @@ -841,6 +841,10 @@ func getURLBase(host string, path string) (*url.URL, error)  {
         return nil, whiskErr
     }
 
+    if !strings.HasPrefix(host, "http") {
 
 Review comment:
   Hmm, what if the string begins with `https://`, won't `https://` be prepended again?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services