You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/04 06:37:43 UTC
[GitHub] [skywalking] zifeihan opened a new pull request #4856: Enhance hystrix plugin
zifeihan opened a new pull request #4856:
URL: https://github.com/apache/skywalking/pull/4856
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
https://github.com/apache/skywalking/issues/4850,
this problem is, origin object HystrixConcurrencyStrategyDefault is wrapped to HystrixConcurrencyStrategy. under hystrix 1.4.3 com.netflix.hystrix.HystrixRequestLog#getCurrentRequest(com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy) this method doesn't check isCurrentThreadInitialized, but checked in other high version
- How to fix?
like hystrix high version, Return null if the {@link HystrixRequestContext} has not been initialized for the current thread.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan closed pull request #4856: Enhance hystrix plugin
Posted by GitBox <gi...@apache.org>.
zifeihan closed pull request #4856:
URL: https://github.com/apache/skywalking/pull/4856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org