You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/22 06:28:58 UTC

[GitHub] [spark] turboFei commented on a change in pull request #26200: [SPARK-29542] Make the description of spark.sql.files.maxPartitionBytes be clearly

turboFei commented on a change in pull request #26200: [SPARK-29542] Make the description of spark.sql.files.maxPartitionBytes be clearly
URL: https://github.com/apache/spark/pull/26200#discussion_r337345178
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -980,7 +980,8 @@ object SQLConf {
       .createWithDefault(true)
 
   val FILES_MAX_PARTITION_BYTES = buildConf("spark.sql.files.maxPartitionBytes")
-    .doc("The maximum number of bytes to pack into a single partition when reading files.")
+    .doc("The maximum number of bytes to pack into a single partition when reading files" +
+      " for data source table.")
 
 Review comment:
   I have checked the configuration of the job I attached in JIRA.
   
   We don't set spark.sql.hive.convertMetastoreParquet, so its value is true with default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org