You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/10 07:58:45 UTC
[GitHub] [pulsar-client-go] labuladong opened a new pull request, #889: feat: add BackoffPolicy to `reader` and improve test case
labuladong opened a new pull request, #889:
URL: https://github.com/apache/pulsar-client-go/pull/889
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #872
### Modifications
Add `BackoffPolicy` for `ReaderOptions` and add tests for `BackoffPolicy`.
Because `Reader` uses `partitionConsumer`, just adding a field in `ReaderOptions` is enough.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change has added tests.
### Does this pull request potentially affect one of the following parts:
- **The public API: (yes)**
- The default values of configurations: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #889: feat: add BackoffPolicy to `reader` and improve test case
Posted by GitBox <gi...@apache.org>.
wolfstudy merged PR #889:
URL: https://github.com/apache/pulsar-client-go/pull/889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] frankjkelly commented on pull request #889: feat: add BackoffPolicy to `reader` and improve test case
Posted by GitBox <gi...@apache.org>.
frankjkelly commented on PR #889:
URL: https://github.com/apache/pulsar-client-go/pull/889#issuecomment-1310763290
LGTM thank you @labuladong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] labuladong commented on pull request #889: feat: add BackoffPolicy to `reader` and improve test case
Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #889:
URL: https://github.com/apache/pulsar-client-go/pull/889#issuecomment-1309909113
PTAL @codelipenghui @frankjkelly @wolfstudy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org