You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/24 17:30:51 UTC
[GitHub] [druid] ccaominh opened a new pull request #9399: Add common
optional dependencies for extensions
ccaominh opened a new pull request #9399: Add common optional dependencies for extensions
URL: https://github.com/apache/druid/pull/9399
Fixes #3435.
### Description
Include hadoop-aws and postgres JDBC connector jar to improve out-of-the-box experience for extensions. The mysql JDBC connector jar is not bundled as it is GPL.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei commented on a change in pull request #9399: Add
common optional dependencies for extensions
Posted by GitBox <gi...@apache.org>.
jon-wei commented on a change in pull request #9399: Add common optional dependencies for extensions
URL: https://github.com/apache/druid/pull/9399#discussion_r383601158
##########
File path: pom.xml
##########
@@ -98,6 +98,7 @@
<netty4.version>4.1.45.Final</netty4.version>
<node.version>v10.14.2</node.version>
<npm.version>6.5.0</npm.version>
+ <postgreql.version>42.2.8</postgreql.version>
Review comment:
postgreql -> postgresql
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9399: Add common optional
dependencies for extensions
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9399: Add common optional dependencies for extensions
URL: https://github.com/apache/druid/pull/9399#issuecomment-590478973
Would you update https://github.com/apache/druid/blob/master/docs/development/extensions-core/lookups-cached-global.md and https://github.com/apache/druid/blob/master/docs/development/extensions-core/druid-lookups.md as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei commented on a change in pull request #9399: Add
common optional dependencies for extensions
Posted by GitBox <gi...@apache.org>.
jon-wei commented on a change in pull request #9399: Add common optional dependencies for extensions
URL: https://github.com/apache/druid/pull/9399#discussion_r383601158
##########
File path: pom.xml
##########
@@ -98,6 +98,7 @@
<netty4.version>4.1.45.Final</netty4.version>
<node.version>v10.14.2</node.version>
<npm.version>6.5.0</npm.version>
+ <postgreql.version>42.2.8</postgreql.version>
Review comment:
posgreql -> postgresql
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on a change in pull request #9399: Add
common optional dependencies for extensions
Posted by GitBox <gi...@apache.org>.
ccaominh commented on a change in pull request #9399: Add common optional dependencies for extensions
URL: https://github.com/apache/druid/pull/9399#discussion_r383603083
##########
File path: pom.xml
##########
@@ -98,6 +98,7 @@
<netty4.version>4.1.45.Final</netty4.version>
<node.version>v10.14.2</node.version>
<npm.version>6.5.0</npm.version>
+ <postgreql.version>42.2.8</postgreql.version>
Review comment:
doh!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9399: Add common optional
dependencies for extensions
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9399: Add common optional dependencies for extensions
URL: https://github.com/apache/druid/pull/9399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei commented on a change in pull request #9399: Add
common optional dependencies for extensions
Posted by GitBox <gi...@apache.org>.
jon-wei commented on a change in pull request #9399: Add common optional dependencies for extensions
URL: https://github.com/apache/druid/pull/9399#discussion_r383542486
##########
File path: pom.xml
##########
@@ -1111,6 +1111,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>42.2.8</version>
Review comment:
nit: suggest moving the version number definition to the `<properties>` section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org