You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2016/02/09 06:17:02 UTC
[jclouds] Add support for Swift conditional copy (#916)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/916
-- Commit Summary --
* Add support for Swift conditional copy
-- File Changes --
M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/ObjectApi.java (29)
A apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/options/CopyOptions.java (48)
M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiLiveTest.java (60)
M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiMockTest.java (26)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/916.patch
https://github.com/jclouds/jclouds/pull/916.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/916
Re: [jclouds] Add support for Swift conditional copy (#916)
Posted by Andrew Gaul <no...@github.com>.
> @@ -323,6 +351,7 @@ void copy(@PathParam("destinationObject") String destinationObject,
> *
> * @throws KeyNotFoundException if the source or destination container do not exist.
> */
> + // TODO: CopyOptions
Need to update these two APIs as above.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/916/files#r52268672
Re: [jclouds] Add support for Swift conditional copy (#916)
Posted by Zack Shoylev <no...@github.com>.
Looks good, what about the TODOs?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/916#issuecomment-181867164
Re: [jclouds] Add support for Swift conditional copy (#916)
Posted by Andrew Gaul <no...@github.com>.
> @@ -323,6 +351,7 @@ void copy(@PathParam("destinationObject") String destinationObject,
> *
> * @throws KeyNotFoundException if the source or destination container do not exist.
> */
> + // TODO: CopyOptions
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/916/files#r52399293
Re: [jclouds] Add support for Swift conditional copy (#916)
Posted by Andrew Gaul <no...@github.com>.
@zack-shoylev Please review.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/916#issuecomment-181714639