You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by brodybits <gi...@git.apache.org> on 2015/04/17 00:50:27 UTC

[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add "Mi...

GitHub user brodybits opened a pull request:

    https://github.com/apache/cordova-windows/pull/69

    Alt for discussion: CB-8866: add "Mixed Platforms" and "Win32" and CB-8869: Windows Universal without Windows 8.0

    This PR is an alternative to PR #67 and PR #68 for discussion and mutually exclusive to both. It is intended to solve two problems in one shot:
    - [CB-8866](https://issues.apache.org/jira/browse/CB-8866): missing "Mixed Platforms" and "Win32" causes problems when installing a plugin such as [Cordova-sqlite-storage](https://github.com/litehelpers/Cordova-sqlite-storage) with C++ component
    - [CB8869](https://issues.apache.org/jira/browse/CB-8869): remove Windows 8.0 from Windows Universal target. The Windows 8.0 target is not supported by some newer tools (such as Visual Studio Express 2013) or Windows Universal plugins (such as [Cordova-sqlite-storage](https://github.com/litehelpers/Cordova-sqlite-storage)), and can confuse newer Windows Universal app developers.
    
    If we cannot drop Windows 8.0 right now, then please ignore this PR as well as PR #68.
    
    As I said in #67 and #68, my ICLA for Apache was already accepted for apache/cordova-wp8#72.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brodybits/cordova-windows CB8866-CB8869

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit 53f6afef36d679bc7193254e8d71b2a7e98d8b6b
Author: Chris Brody <br...@litehelpers.net>
Date:   2015-04-16T22:18:49Z

    CB-8866: add "Mixed Platforms" and "Win32"; CB-8869: Remove Windows 8.0 from Windows Universal

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add "Mi...

Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:

    https://github.com/apache/cordova-windows/pull/69#issuecomment-94813170
  
    Withdrawn for reasons described in #68.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add "Mi...

Posted by brodybits <gi...@git.apache.org>.
Github user brodybits closed the pull request at:

    https://github.com/apache/cordova-windows/pull/69


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org