[jira] [Work logged] (HIVE-23592) Routine "makeIntPair" is Not Correct

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-23592?focusedWorklogId=440145&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440145 ]

ASF GitHub Bot logged work on HIVE-23592:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/20 14:10
            Start Date: 02/Jun/20 14:10
    Worklog Time Spent: 10m 
      Work Description: belugabehr opened a new pull request #1052:
URL: https://github.com/apache/hive/pull/1052


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 440145)
    Remaining Estimate: 0h
            Time Spent: 10m

> Routine "makeIntPair" is Not Correct
> ------------------------------------
>
>                 Key: HIVE-23592
>                 URL: https://issues.apache.org/jira/browse/HIVE-23592
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:java|title=BuddyAllocator.java}
>   // Utility methods used to store pairs of ints as long.
>   private static long makeIntPair(int first, int second) {
>     return ((long)first) << 32 | second;
>   }
>   private static int getFirstInt(long result) {
>     return (int) (result >>> 32);
>   }
>   private static int getSecondInt(long result) {
>     return (int) (result & ((1L << 32) - 1));
>   }
> {code}
> {code:java}
>     long result = LLAP.makeIntPair(Integer.MIN_VALUE, Integer.MIN_VALUE);
>     if (LLAP.getFirstInt(result) != Integer.MIN_VALUE) {
>        throw new Exception();
>     }
>     if (LLAP.getSecondInt(result) != Integer.MIN_VALUE) {
>       throw new Exception();
>    }
> /*
>  * Exception in thread "main" java.lang.Exception
>  * 	at org.test.TestMe.main(TestMe.java:19)
>  */
> {code}
> [https://github.com/apache/hive/blob/4b670877c280b37c5776046f66d766079489b2a8/llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java#L1677]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)