[GitHub] [iceberg] edgarRd commented on pull request #2539: AWS: Remove S3URI usage from public constructors

[GitBox <gi...@apache.org>]

edgarRd commented on pull request #2539:
URL: https://github.com/apache/iceberg/pull/2539#issuecomment-828663523


   @jackye1995 We have an internal implementation of a `FileIO` based on S3, `S3OutputFile` and `S3InputFile` are public so seems like they are already part of a public API, which helps since they are generic enough to handle other S3 use cases we have internally.
   I think the solution proposed by @danielcweeks works for most of the use cases given that `S3InputFile` and `S3OutputFile` are public by removing non-public arguments from the constructors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org