You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Michele Milesi (Jira)" <ji...@apache.org> on 2020/02/27 09:12:00 UTC
[jira] [Commented] (SSHD-970) transferTo function of
SftpRemotePathChannel will loop if count parameter is greater than file
size
[ https://issues.apache.org/jira/browse/SSHD-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046369#comment-17046369 ]
Michele Milesi commented on SSHD-970:
-------------------------------------
Hi [~lgoldstein] ,
I've checked the MR #111 and it does not fix the problem.
The issue is with the test at line 262
{{ while (totalRead < count) {}}
That must be like
{{ while (totalRead < count && !eof) {}}
> transferTo function of SftpRemotePathChannel will loop if count parameter is greater than file size
> ---------------------------------------------------------------------------------------------------
>
> Key: SSHD-970
> URL: https://issues.apache.org/jira/browse/SSHD-970
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.4.1
> Reporter: Michele Milesi
> Assignee: Lyor Goldstein
> Priority: Major
> Labels: patch
> Fix For: 2.4.1
>
> Attachments: SftpRemotePathChannel.patch
>
>
> The method {{transferTo}} of {{SftpRemotePathChannel}} does not checks {{eof}} condition.
> * The exit condition from the reading loop is that totalRead variable is not less than count parameter.
> * At eof the value the method does not increment the totalRead variable
> * If {{count}} parameter value is greater than source file size the value of {{totalRead}} will never reach the {{count}} value
> In order to exit from the loop we need to check the eof condition.
> The attached patch contains:
> * A junit test (added to SftpRemotePathChannelTest.java)
> * A simple fix to the exit condition
> The problem was found on:
> * 2.4.0 released version
> * current git head
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org