You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/19 08:30:38 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #4542: Active HTTP
parameter collection automatically in the profiling context.
wu-sheng opened a new issue #4542: Active HTTP parameter collection automatically in the profiling context.
URL: https://github.com/apache/skywalking/issues/4542
@kezhenxu94 used to add the HTTP parameter collection feature to those plugins, but due to the performance concern, it is default off. Now, as in 7.0.0, we have the profile feature, we know when to activate this.
@mrproliu Let's make the profile feature interactive with the plugins to provide more details of the profiled trace. :)
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] mrproliu commented on issue #4542: Active HTTP
parameter collection automatically in the profiling context.
Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #4542: Active HTTP parameter collection automatically in the profiling context.
URL: https://github.com/apache/skywalking/issues/4542#issuecomment-601136447
I think it's a good idea.
But we have some static plugin configuration is processed based on the enhance mechanism, such as `plugin.mysql.trace_sql_parameter', which may require special processing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4542: Active HTTP
parameter collection automatically in the profiling context.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4542: Active HTTP parameter collection automatically in the profiling context.
URL: https://github.com/apache/skywalking/issues/4542#issuecomment-601143170
Two things, static config is just a condition. We could add a new condition.
Two, sql parameter should be considered carefully, it may impact the performance. I thought just http request parameters, when http span at finish stage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] mrproliu closed issue #4542: Active HTTP parameter
collection automatically in the profiling context.
Posted by GitBox <gi...@apache.org>.
mrproliu closed issue #4542: Active HTTP parameter collection automatically in the profiling context.
URL: https://github.com/apache/skywalking/issues/4542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] mrproliu commented on issue #4542: Active HTTP
parameter collection automatically in the profiling context.
Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #4542: Active HTTP parameter collection automatically in the profiling context.
URL: https://github.com/apache/skywalking/issues/4542#issuecomment-602174525
via #4546
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services