You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2011/05/17 22:49:22 UTC
[pool] GKOP POOL-180 test (testMaxActivePerKeyExceeded) broken
The generics changes made this test no longer test with the expected
pool config. The runTestThreads method uses the protected pool
field and the pool set up in the test was changed to a local
variable in the generics changes.
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] GKOP POOL-180 test (testMaxActivePerKeyExceeded) broken
Posted by Phil Steitz <ph...@gmail.com>.
I have fixed this locally and will commit. The problem was that the tests share a protected pool field that is <String, String> but that test needs <String,Waiter>. That must have caused compilation failure so the pool variable was redeclared locally instead of just set. In any case, I have fixed it and will commit once I have finished testing Mark's latest changes.
On May 17, 2011, at 5:48 PM, sebb <se...@gmail.com> wrote:
> On 17 May 2011 21:49, Phil Steitz <ph...@gmail.com> wrote:
>> The generics changes made this test no longer test with the expected
>> pool config. The runTestThreads method uses the protected pool
>> field and the pool set up in the test was changed to a local
>> variable in the generics changes.
>
> Not sure that was a generics change, though it may have been made at
> the same time. IIRC there were several public or protected fields that
> were deprecated in a previous release, and have now been made private.
> Was it one of those?
>
> If possible, perhaps add a package-protected getter/setter for use by
> the test code only?
>
>> Phil
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] GKOP POOL-180 test (testMaxActivePerKeyExceeded) broken
Posted by sebb <se...@gmail.com>.
On 17 May 2011 21:49, Phil Steitz <ph...@gmail.com> wrote:
> The generics changes made this test no longer test with the expected
> pool config. The runTestThreads method uses the protected pool
> field and the pool set up in the test was changed to a local
> variable in the generics changes.
Not sure that was a generics change, though it may have been made at
the same time. IIRC there were several public or protected fields that
were deprecated in a previous release, and have now been made private.
Was it one of those?
If possible, perhaps add a package-protected getter/setter for use by
the test code only?
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org