You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anurag Singh <an...@gmail.com> on 2016/04/04 19:08:01 UTC

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/
-----------------------------------------------------------

(Updated April 4, 2016, 5:07 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Bugs: MESOS-4610
    https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
-------

Also modified users of MasterContender and MasterDetector to use this
namespace.


Diffs (updated)
-----

  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  include/mesos/v1/scheduler.hpp 52647325c30ead321da66ab595bcb5a9d133a978 
  src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
  src/local/local.cpp 06f6118a5038149f87e970b5cdf7987a270d3fae 
  src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/main.cpp 9dcdbda3fb21096ba954d57fec20a394a009a223 
  src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd 
  src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
  src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 
  src/scheduler/scheduler.cpp 5263a9c549de299434bb835c12c87615b595991a 
  src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 
  src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
  src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
  src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 
  src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768 
  src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 
  src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
  src/tests/container_logger_tests.cpp eff19c85d32f4cba6bbda0202f06985224ee659b 
  src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81 
  src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 
  src/tests/containerizer/filesystem_isolator_tests.cpp b3bd5a03266150a0cd83c966d646a32c419bf512 
  src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d 
  src/tests/containerizer/memory_pressure_tests.cpp be6c3a118b528c39c534da423c15e9dcbb970dbc 
  src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 
  src/tests/containerizer/provisioner_docker_tests.cpp 74bfce40e11c6d4fe7fb70fa044556f3d8d8f6ac 
  src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb 
  src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a 
  src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 
  src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 
  src/tests/executor_http_api_tests.cpp ff7b672e03185fca8b408b8805223a314fa3e483 
  src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d 
  src/tests/fetcher_cache_tests.cpp 798c0cf3ab517d50f1a2f3194faf0fa37954319c 
  src/tests/gc_tests.cpp 89a7f735b27b7a836b4ce3af10f26a6d63887279 
  src/tests/health_check_tests.cpp eace7c35f7240dbdc1bd9dd0a44c2d72127bfa70 
  src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c 
  src/tests/http_fault_tolerance_tests.cpp c06e07daf6d6519c10489310cd4275ae94f302c6 
  src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa 
  src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d 
  src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad 
  src/tests/master_maintenance_tests.cpp b42a81fc2e0982e8fca669bffb798c0acda684fc 
  src/tests/master_quota_tests.cpp c39e3ea3c4b1b46075985501d09ec1b9eaf8f9bd 
  src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 
  src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc 
  src/tests/master_validation_tests.cpp 010479cd18643aad88671b8c6b6f53523786f7a5 
  src/tests/mesos.hpp 98f97101d89cb91ca5e773e7a91f04ee1b8a0d88 
  src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
  src/tests/metrics_tests.cpp 51b4515369b5a72cd9613bb87e7b9df9e1118e83 
  src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
  src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
  src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e 
  src/tests/persistent_volume_endpoints_tests.cpp da5e6eb35cd398bb06e8d2238a1b5f8a09026800 
  src/tests/persistent_volume_tests.cpp 7cb153cc6c0a8ca25cd31096686c63e829f746cf 
  src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 
  src/tests/registrar_zookeeper_tests.cpp 45b687cf96438e2ea8cc94ab2147e2538763e702 
  src/tests/reservation_endpoints_tests.cpp 95a8f3e10a79296f792b12b7148c0d34ad8baf74 
  src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 
  src/tests/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 
  src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 
  src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 
  src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 
  src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd 
  src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda 
  src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e 
  src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
  src/tests/status_update_manager_tests.cpp af989a91ccc6d926aec1526dab1abb8ad9dc7a3d 

Diff: https://reviews.apache.org/r/44288/diff/


Testing
-------

See https://reviews.apache.org/r/44670/.


Thanks,

Anurag Singh


Re: Review Request 44288: Changed MasterDetector/Contender namespace.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/#review127498
-----------------------------------------------------------


Ship it!




Ship It!

- Kapil Arya


On April 6, 2016, 12:02 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44288/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 12:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also modified users of MasterContender and MasterDetector to use this
> namespace.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp 5b153d2acb705cc54fcca86914af72d8b2e3fb55 
>   include/mesos/v1/scheduler.hpp 52647325c30ead321da66ab595bcb5a9d133a978 
>   src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
>   src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e 
>   src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 
>   src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
>   src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c 
>   src/master/master.hpp e5b16f94fa5650b9db44cd7c975adeb5871e16f6 
>   src/master/master.cpp 2cfa5075991bbb5df8a7e33b14767de558bda4ac 
>   src/sched/sched.cpp d740ef630683b61554db58e628333e8a19e9aa27 
>   src/scheduler/scheduler.cpp 5263a9c549de299434bb835c12c87615b595991a 
>   src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea 
>   src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
>   src/slave/slave.cpp 60f93ca2c6251190d5dadfd543f0e5c5fbee1214 
>   src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 
>   src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768 
>   src/tests/cluster.cpp eefc2fa55bca1ad6a53047046fa4f5996d5c3fef 
>   src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
>   src/tests/container_logger_tests.cpp eff19c85d32f4cba6bbda0202f06985224ee659b 
>   src/tests/containerizer/docker_containerizer_tests.cpp a2ac254423449a6e5185fe83177c45ce0d08420f 
>   src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 
>   src/tests/containerizer/filesystem_isolator_tests.cpp b3bd5a03266150a0cd83c966d646a32c419bf512 
>   src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d 
>   src/tests/containerizer/memory_pressure_tests.cpp be6c3a118b528c39c534da423c15e9dcbb970dbc 
>   src/tests/containerizer/port_mapping_tests.cpp ce985f44cffd74a853154309397b8ee596934f78 
>   src/tests/containerizer/provisioner_docker_tests.cpp 74bfce40e11c6d4fe7fb70fa044556f3d8d8f6ac 
>   src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb 
>   src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a 
>   src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 
>   src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 
>   src/tests/executor_http_api_tests.cpp ff7b672e03185fca8b408b8805223a314fa3e483 
>   src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d 
>   src/tests/fetcher_cache_tests.cpp 798c0cf3ab517d50f1a2f3194faf0fa37954319c 
>   src/tests/gc_tests.cpp 68a789cc77b5f1a17b8d002900095b18b1794ddd 
>   src/tests/health_check_tests.cpp 35344d7a3b8fd08da8444c6441c220b02bc1eb8a 
>   src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c 
>   src/tests/http_fault_tolerance_tests.cpp c06e07daf6d6519c10489310cd4275ae94f302c6 
>   src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa 
>   src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d 
>   src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad 
>   src/tests/master_maintenance_tests.cpp b42a81fc2e0982e8fca669bffb798c0acda684fc 
>   src/tests/master_quota_tests.cpp c39e3ea3c4b1b46075985501d09ec1b9eaf8f9bd 
>   src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 
>   src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc 
>   src/tests/master_validation_tests.cpp 010479cd18643aad88671b8c6b6f53523786f7a5 
>   src/tests/mesos.hpp 3b565b45f45c84aba42aa6fb29b21f8306c49861 
>   src/tests/mesos.cpp cf38dbb05908800b3a771318fa6922548c86c1f2 
>   src/tests/metrics_tests.cpp 51b4515369b5a72cd9613bb87e7b9df9e1118e83 
>   src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
>   src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
>   src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e 
>   src/tests/persistent_volume_endpoints_tests.cpp da5e6eb35cd398bb06e8d2238a1b5f8a09026800 
>   src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193 
>   src/tests/reconciliation_tests.cpp 5f2a35efe039da41992057c50e0319c6827f8d22 
>   src/tests/registrar_zookeeper_tests.cpp 45b687cf96438e2ea8cc94ab2147e2538763e702 
>   src/tests/reservation_endpoints_tests.cpp 95a8f3e10a79296f792b12b7148c0d34ad8baf74 
>   src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 
>   src/tests/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 
>   src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 
>   src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 
>   src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 
>   src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd 
>   src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda 
>   src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e 
>   src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
>   src/tests/status_update_manager_tests.cpp af989a91ccc6d926aec1526dab1abb8ad9dc7a3d 
> 
> Diff: https://reviews.apache.org/r/44288/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Re: Review Request 44288: Changed MasterDetector/Contender namespace.

Posted by Anurag Singh <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/
-----------------------------------------------------------

(Updated April 6, 2016, 4:02 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Bugs: MESOS-4610
    https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
-------

Also modified users of MasterContender and MasterDetector to use this
namespace.


Diffs (updated)
-----

  include/mesos/scheduler.hpp 5b153d2acb705cc54fcca86914af72d8b2e3fb55 
  include/mesos/v1/scheduler.hpp 52647325c30ead321da66ab595bcb5a9d133a978 
  src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
  src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e 
  src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c 
  src/master/master.hpp e5b16f94fa5650b9db44cd7c975adeb5871e16f6 
  src/master/master.cpp 2cfa5075991bbb5df8a7e33b14767de558bda4ac 
  src/sched/sched.cpp d740ef630683b61554db58e628333e8a19e9aa27 
  src/scheduler/scheduler.cpp 5263a9c549de299434bb835c12c87615b595991a 
  src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea 
  src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
  src/slave/slave.cpp 60f93ca2c6251190d5dadfd543f0e5c5fbee1214 
  src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 
  src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768 
  src/tests/cluster.cpp eefc2fa55bca1ad6a53047046fa4f5996d5c3fef 
  src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
  src/tests/container_logger_tests.cpp eff19c85d32f4cba6bbda0202f06985224ee659b 
  src/tests/containerizer/docker_containerizer_tests.cpp a2ac254423449a6e5185fe83177c45ce0d08420f 
  src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 
  src/tests/containerizer/filesystem_isolator_tests.cpp b3bd5a03266150a0cd83c966d646a32c419bf512 
  src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d 
  src/tests/containerizer/memory_pressure_tests.cpp be6c3a118b528c39c534da423c15e9dcbb970dbc 
  src/tests/containerizer/port_mapping_tests.cpp ce985f44cffd74a853154309397b8ee596934f78 
  src/tests/containerizer/provisioner_docker_tests.cpp 74bfce40e11c6d4fe7fb70fa044556f3d8d8f6ac 
  src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb 
  src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a 
  src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 
  src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 
  src/tests/executor_http_api_tests.cpp ff7b672e03185fca8b408b8805223a314fa3e483 
  src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d 
  src/tests/fetcher_cache_tests.cpp 798c0cf3ab517d50f1a2f3194faf0fa37954319c 
  src/tests/gc_tests.cpp 68a789cc77b5f1a17b8d002900095b18b1794ddd 
  src/tests/health_check_tests.cpp 35344d7a3b8fd08da8444c6441c220b02bc1eb8a 
  src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c 
  src/tests/http_fault_tolerance_tests.cpp c06e07daf6d6519c10489310cd4275ae94f302c6 
  src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa 
  src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d 
  src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad 
  src/tests/master_maintenance_tests.cpp b42a81fc2e0982e8fca669bffb798c0acda684fc 
  src/tests/master_quota_tests.cpp c39e3ea3c4b1b46075985501d09ec1b9eaf8f9bd 
  src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 
  src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc 
  src/tests/master_validation_tests.cpp 010479cd18643aad88671b8c6b6f53523786f7a5 
  src/tests/mesos.hpp 3b565b45f45c84aba42aa6fb29b21f8306c49861 
  src/tests/mesos.cpp cf38dbb05908800b3a771318fa6922548c86c1f2 
  src/tests/metrics_tests.cpp 51b4515369b5a72cd9613bb87e7b9df9e1118e83 
  src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
  src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
  src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e 
  src/tests/persistent_volume_endpoints_tests.cpp da5e6eb35cd398bb06e8d2238a1b5f8a09026800 
  src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193 
  src/tests/reconciliation_tests.cpp 5f2a35efe039da41992057c50e0319c6827f8d22 
  src/tests/registrar_zookeeper_tests.cpp 45b687cf96438e2ea8cc94ab2147e2538763e702 
  src/tests/reservation_endpoints_tests.cpp 95a8f3e10a79296f792b12b7148c0d34ad8baf74 
  src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 
  src/tests/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 
  src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 
  src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 
  src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 
  src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd 
  src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda 
  src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e 
  src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
  src/tests/status_update_manager_tests.cpp af989a91ccc6d926aec1526dab1abb8ad9dc7a3d 

Diff: https://reviews.apache.org/r/44288/diff/


Testing
-------

See https://reviews.apache.org/r/44670/.


Thanks,

Anurag Singh


Re: Review Request 44288: Changed MasterDetector/Contender namespace.

Posted by Anurag Singh <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/
-----------------------------------------------------------

(Updated April 6, 2016, 3:13 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Bugs: MESOS-4610
    https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
-------

Also modified users of MasterContender and MasterDetector to use this
namespace.


Diffs (updated)
-----

  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  include/mesos/v1/scheduler.hpp 52647325c30ead321da66ab595bcb5a9d133a978 
  src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
  src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e 
  src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c 
  src/master/master.hpp e5b16f94fa5650b9db44cd7c975adeb5871e16f6 
  src/master/master.cpp 2cfa5075991bbb5df8a7e33b14767de558bda4ac 
  src/sched/sched.cpp d740ef630683b61554db58e628333e8a19e9aa27 
  src/scheduler/scheduler.cpp 5263a9c549de299434bb835c12c87615b595991a 
  src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea 
  src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
  src/slave/slave.cpp 60f93ca2c6251190d5dadfd543f0e5c5fbee1214 
  src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 
  src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768 
  src/tests/cluster.cpp eefc2fa55bca1ad6a53047046fa4f5996d5c3fef 
  src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
  src/tests/container_logger_tests.cpp eff19c85d32f4cba6bbda0202f06985224ee659b 
  src/tests/containerizer/docker_containerizer_tests.cpp a2ac254423449a6e5185fe83177c45ce0d08420f 
  src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 
  src/tests/containerizer/filesystem_isolator_tests.cpp b3bd5a03266150a0cd83c966d646a32c419bf512 
  src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d 
  src/tests/containerizer/memory_pressure_tests.cpp be6c3a118b528c39c534da423c15e9dcbb970dbc 
  src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4 
  src/tests/containerizer/provisioner_docker_tests.cpp 74bfce40e11c6d4fe7fb70fa044556f3d8d8f6ac 
  src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb 
  src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a 
  src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 
  src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 
  src/tests/executor_http_api_tests.cpp ff7b672e03185fca8b408b8805223a314fa3e483 
  src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d 
  src/tests/fetcher_cache_tests.cpp 798c0cf3ab517d50f1a2f3194faf0fa37954319c 
  src/tests/gc_tests.cpp 68a789cc77b5f1a17b8d002900095b18b1794ddd 
  src/tests/health_check_tests.cpp 35344d7a3b8fd08da8444c6441c220b02bc1eb8a 
  src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c 
  src/tests/http_fault_tolerance_tests.cpp c06e07daf6d6519c10489310cd4275ae94f302c6 
  src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa 
  src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d 
  src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad 
  src/tests/master_maintenance_tests.cpp b42a81fc2e0982e8fca669bffb798c0acda684fc 
  src/tests/master_quota_tests.cpp c39e3ea3c4b1b46075985501d09ec1b9eaf8f9bd 
  src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 
  src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc 
  src/tests/master_validation_tests.cpp 010479cd18643aad88671b8c6b6f53523786f7a5 
  src/tests/mesos.hpp 98f97101d89cb91ca5e773e7a91f04ee1b8a0d88 
  src/tests/mesos.cpp f31163b49058364fe6d3aa5b41fbf266a4fa5f4f 
  src/tests/metrics_tests.cpp 51b4515369b5a72cd9613bb87e7b9df9e1118e83 
  src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
  src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
  src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e 
  src/tests/persistent_volume_endpoints_tests.cpp da5e6eb35cd398bb06e8d2238a1b5f8a09026800 
  src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193 
  src/tests/reconciliation_tests.cpp 5f2a35efe039da41992057c50e0319c6827f8d22 
  src/tests/registrar_zookeeper_tests.cpp 45b687cf96438e2ea8cc94ab2147e2538763e702 
  src/tests/reservation_endpoints_tests.cpp 95a8f3e10a79296f792b12b7148c0d34ad8baf74 
  src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 
  src/tests/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 
  src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 
  src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 
  src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 
  src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd 
  src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda 
  src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e 
  src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
  src/tests/status_update_manager_tests.cpp af989a91ccc6d926aec1526dab1abb8ad9dc7a3d 

Diff: https://reviews.apache.org/r/44288/diff/


Testing
-------

See https://reviews.apache.org/r/44670/.


Thanks,

Anurag Singh