[GitHub] [bookkeeper] lhotari commented on pull request #2636: ISSUE-2640: BP-43: Gradle: Build bookkeeper-server with gradle and run unit tests

[GitBox <gi...@apache.org>]

lhotari commented on pull request #2636:
URL: https://github.com/apache/bookkeeper/pull/2636#issuecomment-802226134


   > It feels like a good starting point and can evolve. One general question is that I'm not seeing plugin configurations. At least In Pravega, we have them in a `gradle/` folder, see here if it helps:
   > 
   > https://github.com/pravega/pravega/blob/master/build.gradle#L73
   > 
   > If you could clarify what the plan is plugin configurations, I'd appreciate.
   
   Good point. 
   
   Gradle's current recommendation is no more to use "script plugins" such as `apply from: "$rootDir/gradle/java.gradle"` to share build logic. `gradle init` in recent Gradle versions will generate examples of the current recommendation where the shared build logic is put under `buildSrc/src/main/groovy/*-conventions.gradle` files.
   This is documented in https://docs.gradle.org/current/userguide/sharing_build_logic_between_subprojects.html and https://docs.gradle.org/current/samples/sample_convention_plugins.html in the Gradle manual. 
   An example build using Gradle Groovy DSL is in https://github.com/gradle/gradle/tree/master/subprojects/docs/src/samples/build-organization/multi-project-with-convention-plugins/groovy .
   
   When it comes to finding a way how to define plugin configurations, I recommend using the new approach.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org