You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@giraph.apache.org by yavuz gokirmak <yg...@gmail.com> on 2012/02/19 19:47:42 UTC
IntIntNullIntVertex initialize method
Hello,
I am writing my own giraph algorithms to understand the system,
I have again a question about IntIntNullIntVertex
I think IntIntNullIntVertex.initialize method should handle "null" edges
argument
because in VertexResolver.resolve method (line:91) vertex.initialize is
called with edge argument as null.
Finally I wrote my own simple graph algorithm and able to run over girap.
Sorry for newbie questions.
- ygokirmak
Re: IntIntNullIntVertex initialize method
Posted by yavuz gokirmak <yg...@gmail.com>.
I have create https://issues.apache.org/jira/browse/GIRAPH-151
-- ygokirmak
On 19 February 2012 20:53, Sebastian Schelter <ss...@apache.org> wrote:
> That's a good point, can you open a Jira issue for that? Maybe we should
> use some annotation like @Nullable to mark parameters that can be null
> to make it easier to avoid forgetting checks in the implementing code.
>
> --sebastian
>
>
>
> On 19.02.2012 19:47, yavuz gokirmak wrote:
> > Hello,
> >
> > I am writing my own giraph algorithms to understand the system,
> > I have again a question about IntIntNullIntVertex
> >
> > I think IntIntNullIntVertex.initialize method should handle "null" edges
> > argument
> > because in VertexResolver.resolve method (line:91) vertex.initialize is
> > called with edge argument as null.
> >
> > Finally I wrote my own simple graph algorithm and able to run over girap.
> > Sorry for newbie questions.
> >
> > - ygokirmak
> >
>
>
Re: IntIntNullIntVertex initialize method
Posted by Sebastian Schelter <ss...@apache.org>.
That's a good point, can you open a Jira issue for that? Maybe we should
use some annotation like @Nullable to mark parameters that can be null
to make it easier to avoid forgetting checks in the implementing code.
--sebastian
On 19.02.2012 19:47, yavuz gokirmak wrote:
> Hello,
>
> I am writing my own giraph algorithms to understand the system,
> I have again a question about IntIntNullIntVertex
>
> I think IntIntNullIntVertex.initialize method should handle "null" edges
> argument
> because in VertexResolver.resolve method (line:91) vertex.initialize is
> called with edge argument as null.
>
> Finally I wrote my own simple graph algorithm and able to run over girap.
> Sorry for newbie questions.
>
> - ygokirmak
>